about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJed Davis <jld@panix.com>2013-04-30 11:36:22 -0700
committerJed Davis <jld@panix.com>2013-04-30 11:36:22 -0700
commit8408012ca4ed6e8e0aa2aa85e24eb53b4b17308d (patch)
tree4e3006b5025fab89692d736c1f846cd3f40b7fb9
parentc081ffbd1e845687202a975ea2e698b623e5722f (diff)
downloadrust-8408012ca4ed6e8e0aa2aa85e24eb53b4b17308d.tar.gz
rust-8408012ca4ed6e8e0aa2aa85e24eb53b4b17308d.zip
The null case of a nullable-poiner enum might not be nullary.
Cases like `Either<@int,()>` have a null case with at most one value but
a nonzero number of fields; if we misreport this, then bad things can
happen inside of, for example, pattern matching.

Closes #6117.
-rw-r--r--src/librustc/middle/trans/adt.rs4
-rw-r--r--src/test/run-pass/issue-6117.rs16
2 files changed, 18 insertions, 2 deletions
diff --git a/src/librustc/middle/trans/adt.rs b/src/librustc/middle/trans/adt.rs
index b3e24fcc939..0ee2a2c4cb1 100644
--- a/src/librustc/middle/trans/adt.rs
+++ b/src/librustc/middle/trans/adt.rs
@@ -409,8 +409,8 @@ pub fn num_args(r: &Repr, discr: int) -> uint {
             st.fields.len() - (if dtor { 1 } else { 0 })
         }
         General(ref cases) => cases[discr as uint].fields.len() - 1,
-        NullablePointer{ nonnull: ref nonnull, nndiscr, _ } => {
-            if discr == nndiscr { nonnull.fields.len() } else { 0 }
+        NullablePointer{ nonnull: ref nonnull, nndiscr, nullfields: ref nullfields, _ } => {
+            if discr == nndiscr { nonnull.fields.len() } else { nullfields.len() }
         }
     }
 }
diff --git a/src/test/run-pass/issue-6117.rs b/src/test/run-pass/issue-6117.rs
new file mode 100644
index 00000000000..73e9391f016
--- /dev/null
+++ b/src/test/run-pass/issue-6117.rs
@@ -0,0 +1,16 @@
+// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+pub fn main() {
+    match Left(@17) {
+        Right(()) => {}
+        _ => {}
+    }
+}