diff options
| author | bors <bors@rust-lang.org> | 2023-02-15 13:35:49 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-02-15 13:35:49 +0000 |
| commit | 8754d5a6fb98fa9e37b6067322325b4be3d0a388 (patch) | |
| tree | 1e63196bf558d81afac5c92267b082e51c74a8eb | |
| parent | d3d235dcbfbe7818e14c2ecffd074b1c3d8bd37f (diff) | |
| parent | 75aa2b9ec8529a3854a4ebaab1a03438410dc87e (diff) | |
| download | rust-8754d5a6fb98fa9e37b6067322325b4be3d0a388.tar.gz rust-8754d5a6fb98fa9e37b6067322325b4be3d0a388.zip | |
Auto merge of #10343 - samueltardieu:issue-10339, r=Alexendoo
uninlined_format_args: do not inline argument with generic parameters Fix #10339 --- changelog: FP: [`uninlined_format_args`]: No longer lints for arguments with generic parameters [#10343](https://github.com/rust-lang/rust-clippy/pull/10343) <!-- changelog_checked -->
| -rw-r--r-- | clippy_lints/src/format_args.rs | 1 | ||||
| -rw-r--r-- | tests/ui/uninlined_format_args.fixed | 4 | ||||
| -rw-r--r-- | tests/ui/uninlined_format_args.rs | 4 |
3 files changed, 9 insertions, 0 deletions
diff --git a/clippy_lints/src/format_args.rs b/clippy_lints/src/format_args.rs index 92238d557e9..e7caed65bf2 100644 --- a/clippy_lints/src/format_args.rs +++ b/clippy_lints/src/format_args.rs @@ -340,6 +340,7 @@ fn check_one_arg( if matches!(param.kind, Implicit | Starred | Named(_) | Numbered) && let ExprKind::Path(QPath::Resolved(None, path)) = param.value.kind && let [segment] = path.segments + && segment.args.is_none() && let Some(arg_span) = args.value_with_prev_comma_span(param.value.hir_id) { let replacement = match param.usage { diff --git a/tests/ui/uninlined_format_args.fixed b/tests/ui/uninlined_format_args.fixed index 9d08e80cf9a..cbd5cc5fcee 100644 --- a/tests/ui/uninlined_format_args.fixed +++ b/tests/ui/uninlined_format_args.fixed @@ -174,3 +174,7 @@ fn _meets_msrv() { let local_i32 = 1; println!("expand='{local_i32}'"); } + +fn _do_not_fire() { + println!("{:?}", None::<()>); +} diff --git a/tests/ui/uninlined_format_args.rs b/tests/ui/uninlined_format_args.rs index 35b3677a896..cf0ea5be481 100644 --- a/tests/ui/uninlined_format_args.rs +++ b/tests/ui/uninlined_format_args.rs @@ -179,3 +179,7 @@ fn _meets_msrv() { let local_i32 = 1; println!("expand='{}'", local_i32); } + +fn _do_not_fire() { + println!("{:?}", None::<()>); +} |