diff options
| author | Michael Woerister <michaelwoerister@posteo> | 2017-11-29 15:24:18 +0100 |
|---|---|---|
| committer | Michael Woerister <michaelwoerister@posteo> | 2017-11-29 15:24:18 +0100 |
| commit | 89dc8ae205b65326fda2dc9802d4f5e951e62405 (patch) | |
| tree | 0c2944d5ea72b9eccf5b4eb845affbe2ddbf2673 | |
| parent | dc0e227745765c198958f0298785d18bcf61d4ae (diff) | |
| download | rust-89dc8ae205b65326fda2dc9802d4f5e951e62405.tar.gz rust-89dc8ae205b65326fda2dc9802d4f5e951e62405.zip | |
incr.comp.: Remove an unnecessary HIR access which enables hashing spans for type definitions.
| -rw-r--r-- | src/librustc/ich/impls_hir.rs | 20 | ||||
| -rw-r--r-- | src/librustc/ty/mod.rs | 4 |
2 files changed, 10 insertions, 14 deletions
diff --git a/src/librustc/ich/impls_hir.rs b/src/librustc/ich/impls_hir.rs index bccef6dc91b..77bf3da679d 100644 --- a/src/librustc/ich/impls_hir.rs +++ b/src/librustc/ich/impls_hir.rs @@ -884,13 +884,13 @@ impl<'gcx> HashStable<StableHashingContext<'gcx>> for hir::Item { fn hash_stable<W: StableHasherResult>(&self, hcx: &mut StableHashingContext<'gcx>, hasher: &mut StableHasher<W>) { - let (is_const, hash_spans) = match self.node { + let is_const = match self.node { hir::ItemStatic(..) | hir::ItemConst(..) => { - (true, hcx.hash_spans()) + true } hir::ItemFn(_, _, constness, ..) => { - (constness == hir::Constness::Const, hcx.hash_spans()) + constness == hir::Constness::Const } hir::ItemUse(..) | hir::ItemExternCrate(..) | @@ -904,7 +904,7 @@ impl<'gcx> HashStable<StableHashingContext<'gcx>> for hir::Item { hir::ItemEnum(..) | hir::ItemStruct(..) | hir::ItemUnion(..) => { - (false, false) + false } }; @@ -919,13 +919,11 @@ impl<'gcx> HashStable<StableHashingContext<'gcx>> for hir::Item { } = *self; hcx.hash_hir_item_like(attrs, is_const, |hcx| { - hcx.while_hashing_spans(hash_spans, |hcx| { - name.hash_stable(hcx, hasher); - attrs.hash_stable(hcx, hasher); - node.hash_stable(hcx, hasher); - vis.hash_stable(hcx, hasher); - span.hash_stable(hcx, hasher); - }); + name.hash_stable(hcx, hasher); + attrs.hash_stable(hcx, hasher); + node.hash_stable(hcx, hasher); + vis.hash_stable(hcx, hasher); + span.hash_stable(hcx, hasher); }); } } diff --git a/src/librustc/ty/mod.rs b/src/librustc/ty/mod.rs index 583dcb46f00..a63c89a0326 100644 --- a/src/librustc/ty/mod.rs +++ b/src/librustc/ty/mod.rs @@ -2302,9 +2302,7 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> { } pub fn item_name(self, id: DefId) -> InternedString { - if let Some(id) = self.hir.as_local_node_id(id) { - self.hir.name(id).as_str() - } else if id.index == CRATE_DEF_INDEX { + if id.index == CRATE_DEF_INDEX { self.original_crate_name(id.krate).as_str() } else { let def_key = self.def_key(id); |
