diff options
| author | Michael Howell <michael@notriddle.com> | 2024-01-08 09:27:52 -0700 |
|---|---|---|
| committer | Michael Howell <michael@notriddle.com> | 2024-01-08 09:54:05 -0700 |
| commit | 8b52275ee34c829a29bbb677fffd7da48d242616 (patch) | |
| tree | 372b34a1ffbdec6e5d00e13d60ab6929cd0519c8 | |
| parent | 0ee9cfd54db7b5f4be35f026588904500c866196 (diff) | |
| download | rust-8b52275ee34c829a29bbb677fffd7da48d242616.tar.gz rust-8b52275ee34c829a29bbb677fffd7da48d242616.zip | |
rustdoc: hide modals when resizing the sidebar
Follow-up for https://github.com/rust-lang/rust/pull/119477#discussion_r1439085011
| -rw-r--r-- | src/librustdoc/html/static/js/main.js | 1 | ||||
| -rw-r--r-- | tests/rustdoc-gui/sidebar-resize-close-popover.goml | 20 |
2 files changed, 21 insertions, 0 deletions
diff --git a/src/librustdoc/html/static/js/main.js b/src/librustdoc/html/static/js/main.js index 88901191cda..b46701b55ea 100644 --- a/src/librustdoc/html/static/js/main.js +++ b/src/librustdoc/html/static/js/main.js @@ -1721,6 +1721,7 @@ href="https://doc.rust-lang.org/${channel}/rustdoc/read-documentation/search.htm } currentPointerId = e.pointerId; } + window.hideAllModals(false); e.preventDefault(); window.addEventListener("pointermove", resize, false); window.addEventListener("pointercancel", stopResize, false); diff --git a/tests/rustdoc-gui/sidebar-resize-close-popover.goml b/tests/rustdoc-gui/sidebar-resize-close-popover.goml new file mode 100644 index 00000000000..2a8fbac855e --- /dev/null +++ b/tests/rustdoc-gui/sidebar-resize-close-popover.goml @@ -0,0 +1,20 @@ +// Checks sidebar resizing close the Settings popover +go-to: "file://" + |DOC_PATH| + "/test_docs/index.html" +assert-property: (".sidebar", {"clientWidth": "200"}) +show-text: true +click: "#settings-menu" +wait-for: "#settings" +assert-css: ("#settings", {"display": "block"}) +// normal resizing +drag-and-drop: ((205, 100), (185, 100)) +assert-property: (".sidebar", {"clientWidth": "182"}) +assert-css: ("#settings", {"display": "none"}) + +// Now same thing, but for source code +go-to: "file://" + |DOC_PATH| + "/src/test_docs/lib.rs.html" +click: "#settings-menu" +wait-for: "#settings" +assert-css: ("#settings", {"display": "block"}) +assert-property: (".sidebar", {"clientWidth": "49"}) +drag-and-drop: ((52, 100), (185, 100)) +assert-css: ("#settings", {"display": "none"}) |
