about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2018-01-04 14:04:27 +0000
committerbors <bors@rust-lang.org>2018-01-04 14:04:27 +0000
commit8e7a609e635b728eba65d471c985ab462dc4cfc7 (patch)
tree7c339706911647d95974e59f3d4a0163a94ef914
parent4cd918c4caf90ef87d687c02f23b06c581054de3 (diff)
parent238ed47d290849cb5d37f18dbf15c2433fc88c80 (diff)
downloadrust-8e7a609e635b728eba65d471c985ab462dc4cfc7.tar.gz
rust-8e7a609e635b728eba65d471c985ab462dc4cfc7.zip
Auto merge of #46916 - michaelwoerister:generate-dead-code-plz, r=alexcrichton
Generate code for unused const- and inline-fns if -Clink-dead-code is specified.

Fixes https://github.com/rust-lang/rust/issues/46467.

r? @alexcrichton
-rw-r--r--src/librustc_mir/monomorphize/item.rs2
-rw-r--r--src/librustc_mir/monomorphize/partitioning.rs4
-rw-r--r--src/librustc_trans/base.rs8
-rw-r--r--src/test/codegen/link-dead-code.rs27
4 files changed, 38 insertions, 3 deletions
diff --git a/src/librustc_mir/monomorphize/item.rs b/src/librustc_mir/monomorphize/item.rs
index c3fb126ea18..1f463cea764 100644
--- a/src/librustc_mir/monomorphize/item.rs
+++ b/src/librustc_mir/monomorphize/item.rs
@@ -115,7 +115,7 @@ pub trait MonoItemExt<'a, 'tcx>: fmt::Debug {
         let inline_in_all_cgus =
             tcx.sess.opts.debugging_opts.inline_in_all_cgus.unwrap_or_else(|| {
                 tcx.sess.opts.optimize != OptLevel::No
-            });
+            }) && !tcx.sess.opts.cg.link_dead_code;
 
         match *self.as_mono_item() {
             MonoItem::Fn(ref instance) => {
diff --git a/src/librustc_mir/monomorphize/partitioning.rs b/src/librustc_mir/monomorphize/partitioning.rs
index 996195800ce..11c68a11669 100644
--- a/src/librustc_mir/monomorphize/partitioning.rs
+++ b/src/librustc_mir/monomorphize/partitioning.rs
@@ -236,7 +236,9 @@ pub fn partition<'a, 'tcx, I>(tcx: TyCtxt<'a, 'tcx, 'tcx>,
 
     // Next we try to make as many symbols "internal" as possible, so LLVM has
     // more freedom to optimize.
-    internalize_symbols(tcx, &mut post_inlining, inlining_map);
+    if !tcx.sess.opts.cg.link_dead_code {
+        internalize_symbols(tcx, &mut post_inlining, inlining_map);
+    }
 
     // Finally, sort by codegen unit name, so that we get deterministic results
     let PostInliningPartitioning {
diff --git a/src/librustc_trans/base.rs b/src/librustc_trans/base.rs
index 7c8479d1a0c..7bb81e9da34 100644
--- a/src/librustc_trans/base.rs
+++ b/src/librustc_trans/base.rs
@@ -1021,7 +1021,13 @@ fn collect_and_partition_translation_items<'a, 'tcx>(
                 MonoItemCollectionMode::Lazy
             }
         }
-        None => MonoItemCollectionMode::Lazy
+        None => {
+            if tcx.sess.opts.cg.link_dead_code {
+                MonoItemCollectionMode::Eager
+            } else {
+                MonoItemCollectionMode::Lazy
+            }
+        }
     };
 
     let (items, inlining_map) =
diff --git a/src/test/codegen/link-dead-code.rs b/src/test/codegen/link-dead-code.rs
new file mode 100644
index 00000000000..9cabcd9157a
--- /dev/null
+++ b/src/test/codegen/link-dead-code.rs
@@ -0,0 +1,27 @@
+// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+// compile-flags:-Clink-dead-code
+
+#![feature(const_fn)]
+#![crate_type = "rlib"]
+
+// This test makes sure that, when -Clink-dead-code is specified, we generate
+// code for functions that would otherwise be skipped.
+
+// CHECK-LABEL: define hidden i32 @_ZN14link_dead_code8const_fn
+const fn const_fn() -> i32 { 1 }
+
+// CHECK-LABEL: define hidden i32 @_ZN14link_dead_code9inline_fn
+#[inline]
+fn inline_fn() -> i32 { 2 }
+
+// CHECK-LABEL: define hidden i32 @_ZN14link_dead_code10private_fn
+fn private_fn() -> i32 { 3 }