about summary refs log tree commit diff
diff options
context:
space:
mode:
authorScott McMurray <scottmcm@users.noreply.github.com>2023-04-16 04:01:34 -0700
committerScott McMurray <scottmcm@users.noreply.github.com>2023-04-16 04:01:34 -0700
commit99fd9cb6971fc68d6865c2e2cf7722030001f609 (patch)
treef7c339002299df31b2607a6fa245691edfc7e643
parent2a711152615ad9294dc0e5ee6885c8e9bb8418a9 (diff)
downloadrust-99fd9cb6971fc68d6865c2e2cf7722030001f609.tar.gz
rust-99fd9cb6971fc68d6865c2e2cf7722030001f609.zip
Remove the loop in `Align::from_bytes`
Perf is almost certainly irrelevant, but might as well simplify it, since `trailing_zeros` does exactly what's needed.
-rw-r--r--compiler/rustc_abi/src/lib.rs11
1 files changed, 4 insertions, 7 deletions
diff --git a/compiler/rustc_abi/src/lib.rs b/compiler/rustc_abi/src/lib.rs
index b0c0ee942ea..7a3defd2a5d 100644
--- a/compiler/rustc_abi/src/lib.rs
+++ b/compiler/rustc_abi/src/lib.rs
@@ -665,15 +665,12 @@ impl Align {
             format!("`{}` is too large", align)
         }
 
-        let mut bytes = align;
-        let mut pow2: u8 = 0;
-        while (bytes & 1) == 0 {
-            pow2 += 1;
-            bytes >>= 1;
-        }
-        if bytes != 1 {
+        let tz = align.trailing_zeros();
+        if align != (1 << tz) {
             return Err(not_power_of_2(align));
         }
+
+        let pow2 = tz as u8;
         if pow2 > Self::MAX.pow2 {
             return Err(too_large(align));
         }