about summary refs log tree commit diff
diff options
context:
space:
mode:
authorGuillaume Gomez <guillaume1.gomez@gmail.com>2024-04-05 16:38:52 +0200
committerGitHub <noreply@github.com>2024-04-05 16:38:52 +0200
commit9cb517aede5500e80d25a39ba9f079dcf29fb8d4 (patch)
treefe147fdb792edc812a2ed92e2fc38468e53acbcc
parentb0ca3cd9d42d797ccf8a2b172a237921d721dfed (diff)
parent6db7ac6233244c550b3b0a030387419ab2ac9ddd (diff)
downloadrust-9cb517aede5500e80d25a39ba9f079dcf29fb8d4.tar.gz
rust-9cb517aede5500e80d25a39ba9f079dcf29fb8d4.zip
Rollup merge of #123496 - lcnr:wf-ping, r=compiler-errors
ping on wf changes, remove fixme

extend core type system pings to `wf.rs`

r? `@compiler-errors`
-rw-r--r--compiler/rustc_trait_selection/src/traits/wf.rs2
-rw-r--r--triagebot.toml8
2 files changed, 6 insertions, 4 deletions
diff --git a/compiler/rustc_trait_selection/src/traits/wf.rs b/compiler/rustc_trait_selection/src/traits/wf.rs
index 19ca147d3ad..a44a5ae0e6b 100644
--- a/compiler/rustc_trait_selection/src/traits/wf.rs
+++ b/compiler/rustc_trait_selection/src/traits/wf.rs
@@ -714,8 +714,6 @@ impl<'a, 'tcx> TypeVisitor<TyCtxt<'tcx>> for WfPredicates<'a, 'tcx> {
                 // perfect and there may be ways to abuse the fact that we
                 // ignore requirements with escaping bound vars. That's a
                 // more general issue however.
-                //
-                // FIXME(eddyb) add the type to `walker` instead of recursing.
                 let fn_sig = tcx.fn_sig(did).instantiate(tcx, args);
                 fn_sig.output().skip_binder().visit_with(self);
 
diff --git a/triagebot.toml b/triagebot.toml
index 55f0d32398f..3db0f7dc443 100644
--- a/triagebot.toml
+++ b/triagebot.toml
@@ -469,11 +469,11 @@ message = "Some changes occurred in need_type_info.rs"
 cc = ["@lcnr"]
 
 [mentions."compiler/rustc_middle/src/ty/relate.rs"]
-message = "Type relation code was changed"
+message = "changes to the core type system"
 cc = ["@compiler-errors", "@lcnr"]
 
 [mentions."compiler/rustc_infer/src/infer/relate"]
-message = "Type relation code was changed"
+message = "changes to the core type system"
 cc = ["@compiler-errors", "@lcnr"]
 
 [mentions."compiler/rustc_middle/src/mir/interpret"]
@@ -484,6 +484,10 @@ cc = ["@rust-lang/miri"]
 message = "Some changes occurred to MIR optimizations"
 cc = ["@rust-lang/wg-mir-opt"]
 
+[mentions."compiler/rustc_trait_selection/src/traits/wf.rs"]
+message = "changes to the core type system"
+cc = ["@compiler-errors", "@lcnr"]
+
 [mentions."compiler/rustc_trait_selection/src/traits/const_evaluatable.rs"]
 message = "Some changes occurred in `const_evaluatable.rs`"
 cc = ["@BoxyUwU"]