about summary refs log tree commit diff
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2015-08-18 08:51:02 +0000
committerbors <bors@rust-lang.org>2015-08-18 08:51:02 +0000
commita91f19f35662f83cdb20ae8445c941aaff33fc18 (patch)
treea9b133cb94a797267cd4c5bcb274e0350d69370c
parent16cacbe2586fb37521679664798d006cd6831504 (diff)
parentbfc45834c110f7f021daffefcc2290c9133d6139 (diff)
downloadrust-a91f19f35662f83cdb20ae8445c941aaff33fc18.tar.gz
rust-a91f19f35662f83cdb20ae8445c941aaff33fc18.zip
Auto merge of #27869 - alexcrichton:libtest-panic, r=brson
This commit removes the call to `panic!("Some tests failed")` at the end of all
tests run when running with libtest. The panic is replaced with
`std::process::exit` to have a nonzero error code, but this change both:

1. Makes the test runner no longer print out the extraneous panic message at the
   end of a failing test run that some tests failed. (this is already summarized
   in the output of the test run).
2. When running tests with `RUST_BACKTRACE` set it removes an extraneous
   backtrace from the output (only failing tests will have their backtraces in
   the output.
-rw-r--r--src/libtest/lib.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libtest/lib.rs b/src/libtest/lib.rs
index 47c50f70a39..4de7e7c5866 100644
--- a/src/libtest/lib.rs
+++ b/src/libtest/lib.rs
@@ -250,7 +250,7 @@ pub fn test_main(args: &[String], tests: Vec<TestDescAndFn> ) {
         };
     match run_tests_console(&opts, tests) {
         Ok(true) => {}
-        Ok(false) => panic!("Some tests failed"),
+        Ok(false) => std::process::exit(101),
         Err(e) => panic!("io error when running tests: {:?}", e),
     }
 }