diff options
| author | pc-linux <patryk.stachowski@op.pl> | 2023-09-22 18:04:57 +0200 |
|---|---|---|
| committer | pc-linux <patryk.stachowski@op.pl> | 2023-09-22 18:04:57 +0200 |
| commit | ab51f66ec087bfa0159ae19c699cb65049e48efa (patch) | |
| tree | 831754dfa1de35f104293b9867daa6e22cb22086 | |
| parent | 85801f55eff002a63db51125e9bc20aab1d4982e (diff) | |
| download | rust-ab51f66ec087bfa0159ae19c699cb65049e48efa.tar.gz rust-ab51f66ec087bfa0159ae19c699cb65049e48efa.zip | |
added tests
| -rw-r--r-- | tests/ui/needless_pass_by_ref_mut.rs | 12 | ||||
| -rw-r--r-- | tests/ui/needless_pass_by_ref_mut.stderr | 16 |
2 files changed, 24 insertions, 4 deletions
diff --git a/tests/ui/needless_pass_by_ref_mut.rs b/tests/ui/needless_pass_by_ref_mut.rs index da2a72caacb..9cddcb3df23 100644 --- a/tests/ui/needless_pass_by_ref_mut.rs +++ b/tests/ui/needless_pass_by_ref_mut.rs @@ -230,6 +230,18 @@ async fn async_vec(b: &mut Vec<bool>) { async fn async_vec2(b: &mut Vec<bool>) { b.push(true); } +fn non_mut(n: &str) {} +//Should warn +pub async fn call_in_closure1(n: &mut str) { + (|| non_mut(n))() +} +fn str_mut(str: &mut String) -> bool { + str.pop().is_some() +} +//Should not warn +pub async fn call_in_closure2(str: &mut String) { + (|| str_mut(str))(); +} // Should not warn. pub async fn closure(n: &mut usize) -> impl '_ + FnMut() { diff --git a/tests/ui/needless_pass_by_ref_mut.stderr b/tests/ui/needless_pass_by_ref_mut.stderr index 0fb9458d794..0c7fbd5df6d 100644 --- a/tests/ui/needless_pass_by_ref_mut.stderr +++ b/tests/ui/needless_pass_by_ref_mut.stderr @@ -108,7 +108,15 @@ LL | async fn inner_async3(x: &mut i32, y: &mut u32) { | ^^^^^^^^ help: consider changing to: `&i32` error: this argument is a mutable reference, but not used mutably - --> $DIR/needless_pass_by_ref_mut.rs:235:25 + --> $DIR/needless_pass_by_ref_mut.rs:235:34 + | +LL | pub async fn call_in_closure1(n: &mut str) { + | ^^^^^^^^ help: consider changing to: `&str` + | + = warning: changing this function will impact semver compatibility + +error: this argument is a mutable reference, but not used mutably + --> $DIR/needless_pass_by_ref_mut.rs:247:25 | LL | pub async fn closure(n: &mut usize) -> impl '_ + FnMut() { | ^^^^^^^^^^ help: consider changing to: `&usize` @@ -116,7 +124,7 @@ LL | pub async fn closure(n: &mut usize) -> impl '_ + FnMut() { = warning: changing this function will impact semver compatibility error: this argument is a mutable reference, but not used mutably - --> $DIR/needless_pass_by_ref_mut.rs:242:20 + --> $DIR/needless_pass_by_ref_mut.rs:254:20 | LL | pub fn closure2(n: &mut usize) -> impl '_ + FnMut() -> usize { | ^^^^^^^^^^ help: consider changing to: `&usize` @@ -124,12 +132,12 @@ LL | pub fn closure2(n: &mut usize) -> impl '_ + FnMut() -> usize { = warning: changing this function will impact semver compatibility error: this argument is a mutable reference, but not used mutably - --> $DIR/needless_pass_by_ref_mut.rs:253:26 + --> $DIR/needless_pass_by_ref_mut.rs:265:26 | LL | pub async fn closure4(n: &mut usize) { | ^^^^^^^^^^ help: consider changing to: `&usize` | = warning: changing this function will impact semver compatibility -error: aborting due to 20 previous errors +error: aborting due to 21 previous errors |