diff options
| author | bors <bors@rust-lang.org> | 2020-08-22 04:51:38 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2020-08-22 04:51:38 +0000 |
| commit | b57ef14290a91bceebe925bb30a844e89d1de05b (patch) | |
| tree | 4b741681da222d3403f60ec59be15cc099265db8 | |
| parent | aa3b04ff747db336a10945aa90caa361ca552a7f (diff) | |
| parent | 902b28275ef6e06826f269bdf2459c4ba4562145 (diff) | |
| download | rust-b57ef14290a91bceebe925bb30a844e89d1de05b.tar.gz rust-b57ef14290a91bceebe925bb30a844e89d1de05b.zip | |
Auto merge of #5926 - giraffate:improve_lint_message_in_to_string_in_display, r=yaahc
Improve lint message in `to_string_in_display` This is a follow-up of https://github.com/rust-lang/rust-clippy/pull/5831. changelog: none
| -rw-r--r-- | clippy_lints/src/to_string_in_display.rs | 4 | ||||
| -rw-r--r-- | src/lintlist/mod.rs | 2 | ||||
| -rw-r--r-- | tests/ui/to_string_in_display.stderr | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/clippy_lints/src/to_string_in_display.rs b/clippy_lints/src/to_string_in_display.rs index 11bdd27d9b1..4b6a0a6a0c9 100644 --- a/clippy_lints/src/to_string_in_display.rs +++ b/clippy_lints/src/to_string_in_display.rs @@ -39,7 +39,7 @@ declare_clippy_lint! { /// ``` pub TO_STRING_IN_DISPLAY, correctness, - "to_string method used while implementing Display trait" + "`to_string` method used while implementing `Display` trait" } #[derive(Default)] @@ -80,7 +80,7 @@ impl LateLintPass<'_> for ToStringInDisplay { cx, TO_STRING_IN_DISPLAY, expr.span, - "Using to_string in fmt::Display implementation might lead to infinite recursion", + "using `to_string` in `fmt::Display` implementation might lead to infinite recursion", ); } } diff --git a/src/lintlist/mod.rs b/src/lintlist/mod.rs index bf58c117aaa..c50c6b900ae 100644 --- a/src/lintlist/mod.rs +++ b/src/lintlist/mod.rs @@ -2183,7 +2183,7 @@ pub static ref ALL_LINTS: Vec<Lint> = vec![ Lint { name: "to_string_in_display", group: "correctness", - desc: "to_string method used while implementing Display trait", + desc: "`to_string` method used while implementing `Display` trait", deprecation: None, module: "to_string_in_display", }, diff --git a/tests/ui/to_string_in_display.stderr b/tests/ui/to_string_in_display.stderr index cbc0a41036b..5f26ef413e2 100644 --- a/tests/ui/to_string_in_display.stderr +++ b/tests/ui/to_string_in_display.stderr @@ -1,4 +1,4 @@ -error: Using to_string in fmt::Display implementation might lead to infinite recursion +error: using `to_string` in `fmt::Display` implementation might lead to infinite recursion --> $DIR/to_string_in_display.rs:25:25 | LL | write!(f, "{}", self.to_string()) |