about summary refs log tree commit diff
diff options
context:
space:
mode:
authorEsteban Küber <esteban@kuber.com.ar>2019-11-14 11:08:56 -0800
committerEsteban Küber <esteban@kuber.com.ar>2019-11-14 11:08:56 -0800
commitc0a0a7d711b89d89e04a135d6035a2881a7de72e (patch)
treefa92f62b93d328039577cd9620b7ef624b57e9ee
parent7d61484b469aeb9db9c4d7a69c3bf1f24882d183 (diff)
downloadrust-c0a0a7d711b89d89e04a135d6035a2881a7de72e.tar.gz
rust-c0a0a7d711b89d89e04a135d6035a2881a7de72e.zip
review comments
-rw-r--r--src/librustc_typeck/check/generator_interior.rs2
-rw-r--r--src/test/ui/async-await/issue-66387-if-without-else.rs2
2 files changed, 3 insertions, 1 deletions
diff --git a/src/librustc_typeck/check/generator_interior.rs b/src/librustc_typeck/check/generator_interior.rs
index 6e254122c01..6e37c0dbbdf 100644
--- a/src/librustc_typeck/check/generator_interior.rs
+++ b/src/librustc_typeck/check/generator_interior.rs
@@ -245,7 +245,7 @@ impl<'a, 'tcx> Visitor<'tcx> for InteriorVisitor<'a, 'tcx> {
         // If this were not the case, then we could conceivably have
         // to create intermediate temporaries.)
         //
-        // The type table might not have invormation for this expression
+        // The type table might not have information for this expression
         // if it is in a malformed scope. (#66387)
         if let Some(ty) = self.fcx.tables.borrow().expr_ty_opt(expr) {
             self.record(ty, scope, Some(expr), expr.span);
diff --git a/src/test/ui/async-await/issue-66387-if-without-else.rs b/src/test/ui/async-await/issue-66387-if-without-else.rs
index 3602b09c0ec..aa5a8db6121 100644
--- a/src/test/ui/async-await/issue-66387-if-without-else.rs
+++ b/src/test/ui/async-await/issue-66387-if-without-else.rs
@@ -3,6 +3,8 @@ async fn f() -> i32 {
     if true { //~ ERROR if may be missing an else clause
         return 0;
     }
+    // An `if` block without `else` causes the type table not to have a type for this expr.
+    // Check that we do not unconditionally access the type table and we don't ICE.
 }
 
 fn main() {}