diff options
| author | bors <bors@rust-lang.org> | 2022-10-02 07:51:45 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-10-02 07:51:45 +0000 |
| commit | cb8da671949616bde5e8cec995de4c7bd12e12ca (patch) | |
| tree | 9642482edf70ead5ad5c47ce0e350c613cbf7875 | |
| parent | 64243c6f998df7cea3c86488c67481de09fec31c (diff) | |
| parent | 033dae9ecc676a1a6d7fa43665ebff3861f2fa15 (diff) | |
| download | rust-cb8da671949616bde5e8cec995de4c7bd12e12ca.tar.gz rust-cb8da671949616bde5e8cec995de4c7bd12e12ca.zip | |
Auto merge of #9509 - schubart:fix_sorting, r=llogiq
Fix sorting in ` cargo dev update_lints` script changelog: none The old code cloned and sorted `usable_lints` into `sorted_usable_lints`, but then failed to do anything with `sorted_usable_lints`. This was discovered by my new `collection_is_never_read` lint (#9267) that I'm working on! Fix: I renamed the sorted vector to `usable_lints`. Therefore it now gets used where the unsorted one was used previously.
| -rw-r--r-- | clippy_dev/src/update_lints.rs | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/clippy_dev/src/update_lints.rs b/clippy_dev/src/update_lints.rs index 93955bee3f4..0eb443167ec 100644 --- a/clippy_dev/src/update_lints.rs +++ b/clippy_dev/src/update_lints.rs @@ -45,9 +45,8 @@ fn generate_lint_files( renamed_lints: &[RenamedLint], ) { let internal_lints = Lint::internal_lints(lints); - let usable_lints = Lint::usable_lints(lints); - let mut sorted_usable_lints = usable_lints.clone(); - sorted_usable_lints.sort_by_key(|lint| lint.name.clone()); + let mut usable_lints = Lint::usable_lints(lints); + usable_lints.sort_by_key(|lint| lint.name.clone()); replace_region_in_file( update_mode, |