diff options
| author | yukang <moorekang@gmail.com> | 2023-05-13 18:06:16 +0800 |
|---|---|---|
| committer | yukang <moorekang@gmail.com> | 2023-05-13 18:06:16 +0800 |
| commit | ce6cfc37d033eb1fb1f2e3af1c17c218917b54ec (patch) | |
| tree | bed6cfba9c4f2695202b44891c78d26d6dc98256 | |
| parent | 69fef92ab2f287f072b66fb7b4f62c8bb4acba43 (diff) | |
| download | rust-ce6cfc37d033eb1fb1f2e3af1c17c218917b54ec.tar.gz rust-ce6cfc37d033eb1fb1f2e3af1c17c218917b54ec.zip | |
Fix ice caused by shorthand fields in NoFieldsForFnCall
| -rw-r--r-- | compiler/rustc_parse/src/parser/expr.rs | 7 | ||||
| -rw-r--r-- | tests/ui/parser/issues/issue-111416.rs | 4 | ||||
| -rw-r--r-- | tests/ui/parser/issues/issue-111416.stderr | 18 |
3 files changed, 29 insertions, 0 deletions
diff --git a/compiler/rustc_parse/src/parser/expr.rs b/compiler/rustc_parse/src/parser/expr.rs index 887e155426f..808bbbdada6 100644 --- a/compiler/rustc_parse/src/parser/expr.rs +++ b/compiler/rustc_parse/src/parser/expr.rs @@ -1180,6 +1180,13 @@ impl<'a> Parser<'a> { self.restore_snapshot(snapshot); let close_paren = self.prev_token.span; let span = lo.to(close_paren); + // filter shorthand fields + let fields: Vec<_> = fields + .into_iter() + .filter_map( + |field| if !field.is_shorthand { Some(field) } else { None }, + ) + .collect(); if !fields.is_empty() && // `token.kind` should not be compared here. // This is because the `snapshot.token.kind` is treated as the same as diff --git a/tests/ui/parser/issues/issue-111416.rs b/tests/ui/parser/issues/issue-111416.rs new file mode 100644 index 00000000000..deba8679b1a --- /dev/null +++ b/tests/ui/parser/issues/issue-111416.rs @@ -0,0 +1,4 @@ + +fn main() { + let my = monad_bind(mx, T: Try); //~ ERROR invalid `struct` delimiters or `fn` call arguments +} diff --git a/tests/ui/parser/issues/issue-111416.stderr b/tests/ui/parser/issues/issue-111416.stderr new file mode 100644 index 00000000000..b9e61d70e81 --- /dev/null +++ b/tests/ui/parser/issues/issue-111416.stderr @@ -0,0 +1,18 @@ +error: invalid `struct` delimiters or `fn` call arguments + --> $DIR/issue-111416.rs:3:14 + | +LL | let my = monad_bind(mx, T: Try); + | ^^^^^^^^^^^^^^^^^^^^^^ + | +help: if `monad_bind` is a struct, use braces as delimiters + | +LL | let my = monad_bind { mx, T: Try }; + | ~ ~ +help: if `monad_bind` is a function, use the arguments directly + | +LL - let my = monad_bind(mx, T: Try); +LL + let my = monad_bind(mx, Try); + | + +error: aborting due to previous error + |
