about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJohann Hemmann <johann.hemmann@code.berlin>2024-01-22 01:00:13 +0100
committerJohann Hemmann <johann.hemmann@code.berlin>2024-01-31 19:06:18 +0100
commitdaa20725c5e651d2e63f7fbd7d2a8654e9afb6d7 (patch)
treecde14d6a7791fcbfef2ff931f050f6aaa6d74932
parent386d438e173f4c505798361d46f901c7a56567fb (diff)
downloadrust-daa20725c5e651d2e63f7fbd7d2a8654e9afb6d7.tar.gz
rust-daa20725c5e651d2e63f7fbd7d2a8654e9afb6d7.zip
toplevel_ref_arg
-rw-r--r--Cargo.toml1
-rw-r--r--crates/hir-def/src/import_map.rs4
-rw-r--r--crates/hir/src/lib.rs2
3 files changed, 3 insertions, 4 deletions
diff --git a/Cargo.toml b/Cargo.toml
index 099ac296e4d..f49593db5ff 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -180,7 +180,6 @@ non_canonical_clone_impl = "allow"
 non_canonical_partial_ord_impl = "allow"
 self_named_constructors = "allow"
 too_many_arguments = "allow"
-toplevel_ref_arg = "allow"
 type_complexity = "allow"
 unnecessary_cast = "allow"
 unnecessary_filter_map = "allow"
diff --git a/crates/hir-def/src/import_map.rs b/crates/hir-def/src/import_map.rs
index 66d9cf54daa..5d096c7a5e2 100644
--- a/crates/hir-def/src/import_map.rs
+++ b/crates/hir-def/src/import_map.rs
@@ -396,7 +396,7 @@ impl Query {
 pub fn search_dependencies(
     db: &dyn DefDatabase,
     krate: CrateId,
-    ref query: Query,
+    query: &Query,
 ) -> FxHashSet<ItemInNs> {
     let _p = tracing::span!(tracing::Level::INFO, "search_dependencies", ?query).entered();
 
@@ -516,7 +516,7 @@ mod tests {
             })
             .expect("could not find crate");
 
-        let actual = search_dependencies(db.upcast(), krate, query)
+        let actual = search_dependencies(db.upcast(), krate, &query)
             .into_iter()
             .filter_map(|dependency| {
                 let dependency_krate = dependency.krate(db.upcast())?;
diff --git a/crates/hir/src/lib.rs b/crates/hir/src/lib.rs
index 28decd4ce71..2c5474c5c88 100644
--- a/crates/hir/src/lib.rs
+++ b/crates/hir/src/lib.rs
@@ -236,7 +236,7 @@ impl Crate {
         query: import_map::Query,
     ) -> impl Iterator<Item = Either<ModuleDef, Macro>> {
         let _p = tracing::span!(tracing::Level::INFO, "query_external_importables");
-        import_map::search_dependencies(db, self.into(), query).into_iter().map(|item| {
+        import_map::search_dependencies(db, self.into(), &query).into_iter().map(|item| {
             match ItemInNs::from(item) {
                 ItemInNs::Types(mod_id) | ItemInNs::Values(mod_id) => Either::Left(mod_id),
                 ItemInNs::Macros(mac_id) => Either::Right(mac_id),