diff options
| author | Jason Newcomb <jsnewcomb@pm.me> | 2024-06-16 01:41:56 -0400 |
|---|---|---|
| committer | Jason Newcomb <jsnewcomb@pm.me> | 2024-07-07 22:17:43 -0400 |
| commit | e12ff630fde5fb331b32cb2831fd164497df8f27 (patch) | |
| tree | 898836b1ee40e27a127e9bf0adf29ed6e3dca35b | |
| parent | 15eac5abd684a38df7643183ef2874432d960d9c (diff) | |
| download | rust-e12ff630fde5fb331b32cb2831fd164497df8f27.tar.gz rust-e12ff630fde5fb331b32cb2831fd164497df8f27.zip | |
`permissions_set_readonly_false`: Check HIR tree first.
| -rw-r--r-- | clippy_lints/src/permissions_set_readonly_false.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clippy_lints/src/permissions_set_readonly_false.rs b/clippy_lints/src/permissions_set_readonly_false.rs index 704acdc103e..dc142b6e157 100644 --- a/clippy_lints/src/permissions_set_readonly_false.rs +++ b/clippy_lints/src/permissions_set_readonly_false.rs @@ -31,10 +31,10 @@ declare_lint_pass!(PermissionsSetReadonlyFalse => [PERMISSIONS_SET_READONLY_FALS impl<'tcx> LateLintPass<'tcx> for PermissionsSetReadonlyFalse { fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'tcx>) { if let ExprKind::MethodCall(path, receiver, [arg], _) = &expr.kind - && is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(receiver), sym::FsPermissions) - && path.ident.name == sym!(set_readonly) && let ExprKind::Lit(lit) = &arg.kind && LitKind::Bool(false) == lit.node + && path.ident.name.as_str() == "set_readonly" + && is_type_diagnostic_item(cx, cx.typeck_results().expr_ty(receiver), sym::FsPermissions) { span_lint_and_then( cx, |