diff options
| author | bors <bors@rust-lang.org> | 2023-02-10 07:14:50 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-02-10 07:14:50 +0000 |
| commit | e2b868c5340a044b619faedd4f8436d0aec9ae47 (patch) | |
| tree | 9e2ab0eb5b724b86ff4553f1c42ada0eab6ae926 | |
| parent | c468e39b5a371f1a85dfe5ebece82caad0796c0a (diff) | |
| parent | 626dc651ff41e718abc5c21261cf2b95801a2b90 (diff) | |
| download | rust-e2b868c5340a044b619faedd4f8436d0aec9ae47.tar.gz rust-e2b868c5340a044b619faedd4f8436d0aec9ae47.zip | |
Auto merge of #14114 - lh123:insert-ws-when-inline-macro, r=lnicola
fix: Insert spaces when inlining macros Fixes https://github.com/rust-lang/rust-analyzer/issues/14108
| -rw-r--r-- | crates/ide-assists/src/handlers/inline_macro.rs | 26 |
1 files changed, 25 insertions, 1 deletions
diff --git a/crates/ide-assists/src/handlers/inline_macro.rs b/crates/ide-assists/src/handlers/inline_macro.rs index 9d03f03d201..3fc552306a6 100644 --- a/crates/ide-assists/src/handlers/inline_macro.rs +++ b/crates/ide-assists/src/handlers/inline_macro.rs @@ -1,3 +1,4 @@ +use ide_db::syntax_helpers::insert_whitespace_into_node::insert_ws_into; use syntax::ast::{self, AstNode}; use crate::{AssistContext, AssistId, AssistKind, Assists}; @@ -35,7 +36,7 @@ use crate::{AssistContext, AssistId, AssistKind, Assists}; // ``` pub(crate) fn inline_macro(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> { let unexpanded = ctx.find_node_at_offset::<ast::MacroCall>()?; - let expanded = ctx.sema.expand(&unexpanded)?.clone_for_update(); + let expanded = insert_ws_into(ctx.sema.expand(&unexpanded)?.clone_for_update()); let text_range = unexpanded.syntax().text_range(); @@ -230,4 +231,27 @@ fn f() { let result = foo$0(); } "#, ); } + + #[test] + fn inline_macro_with_whitespace() { + check_assist( + inline_macro, + r#" +macro_rules! whitespace { + () => { + if true {} + }; +} +fn f() { whitespace$0!(); } +"#, + r#" +macro_rules! whitespace { + () => { + if true {} + }; +} +fn f() { if true{}; } +"#, + ) + } } |
