diff options
| author | Matthias Krüger <matthias.krueger@famsik.de> | 2024-11-13 21:04:25 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-13 21:04:25 +0100 |
| commit | e6b3a55b985e2a9a0c631561b22aca4524674645 (patch) | |
| tree | bdc1995f3384a6d674640e0cfe362ab2fd871079 | |
| parent | a1923b3bf990340033b3e6211ac83418a0fd41eb (diff) | |
| parent | 1136bbf0668d84d2b4b09b772e33fd8532994f83 (diff) | |
| download | rust-e6b3a55b985e2a9a0c631561b22aca4524674645.tar.gz rust-e6b3a55b985e2a9a0c631561b22aca4524674645.zip | |
Rollup merge of #132996 - clubby789:unn-let-space, r=jieyouxu
Trim extra space when suggesting removing bad `let` Fixes #132969
| -rw-r--r-- | compiler/rustc_parse/src/parser/pat.rs | 4 | ||||
| -rw-r--r-- | tests/ui/parser/unnecessary-let.stderr | 8 |
2 files changed, 7 insertions, 5 deletions
diff --git a/compiler/rustc_parse/src/parser/pat.rs b/compiler/rustc_parse/src/parser/pat.rs index 7f114013320..3546e5b0f04 100644 --- a/compiler/rustc_parse/src/parser/pat.rs +++ b/compiler/rustc_parse/src/parser/pat.rs @@ -683,7 +683,9 @@ impl<'a> Parser<'a> { }) { self.bump(); - self.dcx().emit_err(RemoveLet { span: lo }); + // Trim extra space after the `let` + let span = lo.with_hi(self.token.span.lo()); + self.dcx().emit_err(RemoveLet { span }); lo = self.token.span; } diff --git a/tests/ui/parser/unnecessary-let.stderr b/tests/ui/parser/unnecessary-let.stderr index c6ac0d562f8..05ac1faafd4 100644 --- a/tests/ui/parser/unnecessary-let.stderr +++ b/tests/ui/parser/unnecessary-let.stderr @@ -2,12 +2,12 @@ error: expected pattern, found `let` --> $DIR/unnecessary-let.rs:2:9 | LL | for let x of [1, 2, 3] {} - | ^^^ + | ^^^^ | help: remove the unnecessary `let` keyword | LL - for let x of [1, 2, 3] {} -LL + for x of [1, 2, 3] {} +LL + for x of [1, 2, 3] {} | error: missing `in` in `for` loop @@ -25,12 +25,12 @@ error: expected pattern, found `let` --> $DIR/unnecessary-let.rs:7:9 | LL | let 1 => {} - | ^^^ + | ^^^^ | help: remove the unnecessary `let` keyword | LL - let 1 => {} -LL + 1 => {} +LL + 1 => {} | error: aborting due to 3 previous errors |