diff options
| author | Aaron Hill <aa1ronham@gmail.com> | 2021-11-26 09:14:16 -0600 |
|---|---|---|
| committer | Aaron Hill <aa1ronham@gmail.com> | 2021-11-27 11:33:55 -0600 |
| commit | 3c8b644d0d7d6fcd56db2184d4b5622d9e50ca37 (patch) | |
| tree | a26f6b93e0549a4750338f6739ac2d36f2be1593 | |
| parent | 6b997b657657f7c63cf2e377dfc60d38da5bfe1d (diff) | |
| download | rust-3c8b644d0d7d6fcd56db2184d4b5622d9e50ca37.tar.gz rust-3c8b644d0d7d6fcd56db2184d4b5622d9e50ca37.zip | |
Only check for errors in predicate when skipping impl assembly
Prior to PR #91205, checking for errors in the overall obligation would check checking the `ParamEnv`, due to an incorrect `super_visit_with` impl. With this bug fixed, we will now bail out of impl candidate assembly if the `ParamEnv` contains any error types. In practice, this appears to be overly conservative - when an error occurs early in compilation, we end up giving up early for some predicates that we could have successfully evaluated without overflow. By only checking for errors in the predicate itself, we avoid causing additional spurious 'type annotations needed' errors after a 'real' error has already occurred. With this PR, the diagnostic changes caused by PR #91205 are reverted.
| -rw-r--r-- | tests/ui/crashes/ice-6252.stderr | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/tests/ui/crashes/ice-6252.stderr b/tests/ui/crashes/ice-6252.stderr index abca7af30a0..c8239897f3a 100644 --- a/tests/ui/crashes/ice-6252.stderr +++ b/tests/ui/crashes/ice-6252.stderr @@ -21,15 +21,16 @@ LL | impl<N, M> TypeVal<usize> for Multiply<N, M> where N: TypeVal<VAL> {} | | | help: you might be missing a type parameter: `, VAL` -error[E0283]: type annotations needed - --> $DIR/ice-6252.rs:10:12 +error[E0046]: not all trait items implemented, missing: `VAL` + --> $DIR/ice-6252.rs:10:1 | +LL | const VAL: T; + | ------------- `VAL` from trait +... LL | impl<N, M> TypeVal<usize> for Multiply<N, M> where N: TypeVal<VAL> {} - | ^^^^^^^^^^^^^^ cannot infer type for struct `Multiply<N, M>` - | - = note: cannot satisfy `Multiply<N, M>: TypeVal<usize>` + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `VAL` in implementation error: aborting due to 3 previous errors -Some errors have detailed explanations: E0283, E0412. -For more information about an error, try `rustc --explain E0283`. +Some errors have detailed explanations: E0046, E0412. +For more information about an error, try `rustc --explain E0046`. |