diff options
| author | Josh Triplett <josh@joshtriplett.org> | 2021-12-31 21:13:07 -0800 |
|---|---|---|
| committer | Josh Triplett <josh@joshtriplett.org> | 2021-12-31 21:13:07 -0800 |
| commit | f5bbd1b5299da31532d00abb0502feb5b60f2606 (patch) | |
| tree | 51050a4b1040bb78cd59a4ace8ac9af15307a71a | |
| parent | 1f3d6a669e3af1880f4ae923e7051bc37275a6ae (diff) | |
| download | rust-f5bbd1b5299da31532d00abb0502feb5b60f2606.tar.gz rust-f5bbd1b5299da31532d00abb0502feb5b60f2606.zip | |
Make tidy check for magic numbers that spell things
Remove existing problematic cases.
| -rw-r--r-- | tests/ui/unreadable_literal.fixed | 2 | ||||
| -rw-r--r-- | tests/ui/unreadable_literal.rs | 2 | ||||
| -rw-r--r-- | tests/ui/unreadable_literal.stderr | 10 |
3 files changed, 7 insertions, 7 deletions
diff --git a/tests/ui/unreadable_literal.fixed b/tests/ui/unreadable_literal.fixed index c2e38037add..e726b652ef1 100644 --- a/tests/ui/unreadable_literal.fixed +++ b/tests/ui/unreadable_literal.fixed @@ -30,7 +30,7 @@ fn main() { 1_234.123_f32, 1.123_4_f32, ); - let _bad = (0b11_0110_i64, 0xcafe_babe_usize, 123_456_f32, 1.234_567_f32); + let _bad = (0b11_0110_i64, 0x1234_5678_usize, 123_456_f32, 1.234_567_f32); let _good_sci = 1.1234e1; let _bad_sci = 1.123_456e1; diff --git a/tests/ui/unreadable_literal.rs b/tests/ui/unreadable_literal.rs index 8296945b25e..5bbb2fc9dc1 100644 --- a/tests/ui/unreadable_literal.rs +++ b/tests/ui/unreadable_literal.rs @@ -30,7 +30,7 @@ fn main() { 1_234.123_f32, 1.123_4_f32, ); - let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32); + let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32); let _good_sci = 1.1234e1; let _bad_sci = 1.123456e1; diff --git a/tests/ui/unreadable_literal.stderr b/tests/ui/unreadable_literal.stderr index 8436aac17ac..ee5466fd517 100644 --- a/tests/ui/unreadable_literal.stderr +++ b/tests/ui/unreadable_literal.stderr @@ -9,7 +9,7 @@ LL | 0x1_234_567, error: long literal lacking separators --> $DIR/unreadable_literal.rs:33:17 | -LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32); +LL | let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32); | ^^^^^^^^^^^^ help: consider: `0b11_0110_i64` | = note: `-D clippy::unreadable-literal` implied by `-D warnings` @@ -17,19 +17,19 @@ LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32); error: long literal lacking separators --> $DIR/unreadable_literal.rs:33:31 | -LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32); - | ^^^^^^^^^^^^^^^^ help: consider: `0xcafe_babe_usize` +LL | let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32); + | ^^^^^^^^^^^^^^^^ help: consider: `0x1234_5678_usize` error: long literal lacking separators --> $DIR/unreadable_literal.rs:33:49 | -LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32); +LL | let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32); | ^^^^^^^^^^ help: consider: `123_456_f32` error: long literal lacking separators --> $DIR/unreadable_literal.rs:33:61 | -LL | let _bad = (0b110110_i64, 0xcafebabe_usize, 123456_f32, 1.234567_f32); +LL | let _bad = (0b110110_i64, 0x12345678_usize, 123456_f32, 1.234567_f32); | ^^^^^^^^^^^^ help: consider: `1.234_567_f32` error: long literal lacking separators |