diff options
| author | Jason Newcomb <jsnewcomb@pm.me> | 2024-02-24 17:22:28 -0500 |
|---|---|---|
| committer | Jason Newcomb <jsnewcomb@pm.me> | 2024-03-05 13:28:15 -0500 |
| commit | 0901b9fecf32c7dd84c83c454d30cbce11cbf2ea (patch) | |
| tree | 425992639de3bc52f3b833c005dc086f1ecf6666 | |
| parent | ae710de635e074d86ac0df873842087f67c2c3d4 (diff) | |
| download | rust-0901b9fecf32c7dd84c83c454d30cbce11cbf2ea.tar.gz rust-0901b9fecf32c7dd84c83c454d30cbce11cbf2ea.zip | |
Convert `TypeVisitor` and `DefIdVisitor` to use `VisitorResult`
| -rw-r--r-- | clippy_lints/src/methods/useless_asref.rs | 4 | ||||
| -rw-r--r-- | clippy_utils/src/mir/possible_borrower.rs | 4 | ||||
| -rw-r--r-- | clippy_utils/src/ty.rs | 6 |
3 files changed, 7 insertions, 7 deletions
diff --git a/clippy_lints/src/methods/useless_asref.rs b/clippy_lints/src/methods/useless_asref.rs index 514015af045..b8baad18cc8 100644 --- a/clippy_lints/src/methods/useless_asref.rs +++ b/clippy_lints/src/methods/useless_asref.rs @@ -22,9 +22,9 @@ fn get_enum_ty(enum_ty: Ty<'_>) -> Option<Ty<'_>> { } impl<'tcx> TypeVisitor<TyCtxt<'tcx>> for ContainsTyVisitor { - type BreakTy = Ty<'tcx>; + type Result = ControlFlow<Ty<'tcx>>; - fn visit_ty(&mut self, t: Ty<'tcx>) -> ControlFlow<Self::BreakTy> { + fn visit_ty(&mut self, t: Ty<'tcx>) -> Self::Result { self.level += 1; if self.level == 1 { t.super_visit_with(self) diff --git a/clippy_utils/src/mir/possible_borrower.rs b/clippy_utils/src/mir/possible_borrower.rs index f9cc5f19125..06229ac938f 100644 --- a/clippy_utils/src/mir/possible_borrower.rs +++ b/clippy_utils/src/mir/possible_borrower.rs @@ -141,9 +141,9 @@ impl<'a, 'b, 'tcx> mir::visit::Visitor<'tcx> for PossibleBorrowerVisitor<'a, 'b, struct ContainsRegion; impl TypeVisitor<TyCtxt<'_>> for ContainsRegion { - type BreakTy = (); + type Result = ControlFlow<()>; - fn visit_region(&mut self, _: ty::Region<'_>) -> ControlFlow<Self::BreakTy> { + fn visit_region(&mut self, _: ty::Region<'_>) -> Self::Result { ControlFlow::Break(()) } } diff --git a/clippy_utils/src/ty.rs b/clippy_utils/src/ty.rs index 6762c883005..6e011a28bb7 100644 --- a/clippy_utils/src/ty.rs +++ b/clippy_utils/src/ty.rs @@ -916,8 +916,8 @@ pub fn for_each_top_level_late_bound_region<B>( f: F, } impl<'tcx, B, F: FnMut(BoundRegion) -> ControlFlow<B>> TypeVisitor<TyCtxt<'tcx>> for V<F> { - type BreakTy = B; - fn visit_region(&mut self, r: Region<'tcx>) -> ControlFlow<Self::BreakTy> { + type Result = ControlFlow<B>; + fn visit_region(&mut self, r: Region<'tcx>) -> Self::Result { if let RegionKind::ReBound(idx, bound) = r.kind() && idx.as_u32() == self.index { @@ -926,7 +926,7 @@ pub fn for_each_top_level_late_bound_region<B>( ControlFlow::Continue(()) } } - fn visit_binder<T: TypeVisitable<TyCtxt<'tcx>>>(&mut self, t: &Binder<'tcx, T>) -> ControlFlow<Self::BreakTy> { + fn visit_binder<T: TypeVisitable<TyCtxt<'tcx>>>(&mut self, t: &Binder<'tcx, T>) -> Self::Result { self.index += 1; let res = t.super_visit_with(self); self.index -= 1; |
