diff options
| author | Trevor Gross <t.gross35@gmail.com> | 2025-09-06 14:39:05 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-09-06 14:39:05 -0400 |
| commit | 865c99a09281af69e37cdd994f3c9b7a72fd8317 (patch) | |
| tree | 5a437098c40a40923d63594b408e2b47baa31586 | |
| parent | d3d5c7f9bd042f9c67733544d5dcc665ae25dc31 (diff) | |
| parent | 6c4e958fad41710337b9827a0a8cb351e78a838f (diff) | |
| download | rust-865c99a09281af69e37cdd994f3c9b7a72fd8317.tar.gz rust-865c99a09281af69e37cdd994f3c9b7a72fd8317.zip | |
Rollup merge of #146272 - rperier:rustc_llvm_werror_remove_commment_llvm22, r=tgross35
Update comment for `-Werror` on LLVM builds cc rust-lang/rust#109712 see https://github.com/rust-lang/rust/issues/109712#issuecomment-3257474643
| -rw-r--r-- | compiler/rustc_llvm/build.rs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/compiler/rustc_llvm/build.rs b/compiler/rustc_llvm/build.rs index d01f79dcade..225ab8c846d 100644 --- a/compiler/rustc_llvm/build.rs +++ b/compiler/rustc_llvm/build.rs @@ -174,10 +174,10 @@ fn main() { // Prevent critical warnings when we're compiling from rust-lang/rust CI, // except on MSVC, as the compiler throws warnings that are only reported - // for this platform. See https://github.com/rust-lang/rust/pull/145031#issuecomment-3162677202 - // FIXME(llvm22): It looks like the specific problem code has been removed - // in https://github.com/llvm/llvm-project/commit/e8fc808bf8e78a3c80d1f8e293a92677b92366dd, - // retry msvc once we bump our LLVM version. + // for this platform. See https://github.com/rust-lang/rust/pull/145031#issuecomment-3162677202. + // Moreover, LLVM generally guarantees warning-freedom only when building with Clang, as other + // compilers have too many false positives. This is typically the case for MSVC, which throws + // many false-positive warnings. We keep it excluded, for these reasons. if std::env::var_os("CI").is_some() && !target.contains("msvc") { cfg.warnings_into_errors(true); } |