diff options
| author | bors <bors@rust-lang.org> | 2022-09-18 14:10:57 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-09-18 14:10:57 +0000 |
| commit | a37499ae66ec5fc52a93d71493b78fb141c32f6b (patch) | |
| tree | 26d26f1a75711967d423745d419c8bd98ed14808 | |
| parent | 4af79ccd5e23c7cbaabcd7aefdda3b715abde606 (diff) | |
| parent | bd5aad3ee28fbc1f7cb4bd2c52763dbadaeae34a (diff) | |
| download | rust-a37499ae66ec5fc52a93d71493b78fb141c32f6b.tar.gz rust-a37499ae66ec5fc52a93d71493b78fb141c32f6b.zip | |
Auto merge of #101332 - sashashura:patch-1, r=pietroalbini
GitHub Workflows security hardening This PR adds explicit [permissions section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions) to workflows. This is a security best practice because by default workflows run with [extended set of permissions](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token) (except from `on: pull_request` [from external forks](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/)). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an [injection](https://securitylab.github.com/research/github-actions-untrusted-input/) or compromised third party tool or action) is restricted. It is recommended to have [most strict permissions on the top level](https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions) and grant write permissions on [job level](https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs) case by case.
| -rw-r--r-- | .github/workflows/ci.yml | 8 | ||||
| -rw-r--r-- | src/ci/github-actions/ci.yml | 9 |
2 files changed, 17 insertions, 0 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ec1ef041b20..6693182e0c5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,11 +25,15 @@ name: CI pull_request: branches: - "**" +permissions: + contents: read defaults: run: shell: bash jobs: pr: + permissions: + actions: write name: PR env: CI_JOB_NAME: "${{ matrix.name }}" @@ -142,6 +146,8 @@ jobs: AWS_SECRET_ACCESS_KEY: "${{ secrets[format('AWS_SECRET_ACCESS_KEY_{0}', env.ARTIFACTS_AWS_ACCESS_KEY_ID)] }}" if: "success() && !env.SKIP_JOB && (github.event_name == 'push' || env.DEPLOY == '1' || env.DEPLOY_ALT == '1')" auto: + permissions: + actions: write name: auto env: CI_JOB_NAME: "${{ matrix.name }}" @@ -547,6 +553,8 @@ jobs: AWS_SECRET_ACCESS_KEY: "${{ secrets[format('AWS_SECRET_ACCESS_KEY_{0}', env.ARTIFACTS_AWS_ACCESS_KEY_ID)] }}" if: "success() && !env.SKIP_JOB && (github.event_name == 'push' || env.DEPLOY == '1' || env.DEPLOY_ALT == '1')" try: + permissions: + actions: write name: try env: CI_JOB_NAME: "${{ matrix.name }}" diff --git a/src/ci/github-actions/ci.yml b/src/ci/github-actions/ci.yml index 7826fd51409..f020c31079e 100644 --- a/src/ci/github-actions/ci.yml +++ b/src/ci/github-actions/ci.yml @@ -264,6 +264,9 @@ on: branches: - "**" +permissions: + contents: read + defaults: run: # On Linux, macOS, and Windows, use the system-provided bash as the default @@ -273,6 +276,8 @@ defaults: jobs: pr: + permissions: + actions: write # for rust-lang/simpleinfra/github-actions/cancel-outdated-builds <<: *base-ci-job name: PR env: @@ -293,6 +298,8 @@ jobs: <<: *job-linux-xl auto: + permissions: + actions: write # for rust-lang/simpleinfra/github-actions/cancel-outdated-builds <<: *base-ci-job name: auto env: @@ -719,6 +726,8 @@ jobs: <<: *job-windows-xl try: + permissions: + actions: write # for rust-lang/simpleinfra/github-actions/cancel-outdated-builds <<: *base-ci-job name: try env: |