diff options
| author | Corey Farwell <coreyf@rwell.org> | 2018-08-17 08:23:45 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-08-17 08:23:45 -0700 |
| commit | f2146667affe8dc662cc1a44d293efb4a7d8cc0f (patch) | |
| tree | 90116a7f529330a988989b1468b0260679a7d11f | |
| parent | 5c7b837c4e0b7405726440533393c68521acfefe (diff) | |
| parent | ed39cc074aa5d25ec8d7fc2e17b69bf97c148cda (diff) | |
| download | rust-f2146667affe8dc662cc1a44d293efb4a7d8cc0f.tar.gz rust-f2146667affe8dc662cc1a44d293efb4a7d8cc0f.zip | |
Rollup merge of #53434 - alexcrichton:remove-strip-debug, r=yurydelendik
wasm: Remove --strip-debug argument to LLD Originally added in #52887 this commit disables passing `--strip-debug` to LLD when optimized. This bring back the original bug of emitting broken debuginfo but currently it *also* strips the `name` section which makes it very difficult to inspect the final binary. A real fix is happening at https://reviews.llvm.org/D50729 and we can reevaluate once we've updated LLD to have that commit.
| -rw-r--r-- | src/librustc_codegen_llvm/back/linker.rs | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/src/librustc_codegen_llvm/back/linker.rs b/src/librustc_codegen_llvm/back/linker.rs index ef98fae9cc7..6311ab7c74c 100644 --- a/src/librustc_codegen_llvm/back/linker.rs +++ b/src/librustc_codegen_llvm/back/linker.rs @@ -1006,18 +1006,6 @@ impl<'a> Linker for WasmLd<'a> { OptLevel::Size => "-O2", OptLevel::SizeMin => "-O2" }); - match self.sess.opts.optimize { - OptLevel::No => (), - OptLevel::Less | - OptLevel::Default | - OptLevel::Aggressive | - OptLevel::Size | - OptLevel::SizeMin => { - // LLD generates incorrect debugging information when - // optimization is applied: strip debug sections. - self.cmd.arg("--strip-debug"); - } - } } fn pgo_gen(&mut self) { |