diff options
| author | Yuki Okushi <huyuumi.dev@gmail.com> | 2019-10-23 17:14:29 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-10-23 17:14:29 +0900 |
| commit | bd82de0de69d72fcdb9054c70d2a1ee8328e5480 (patch) | |
| tree | 7ca7d524337e7aa90a5f8d02004d1c26aeb1f1d9 /CONTRIBUTING.md | |
| parent | 86992272d5de57ba38bcc25e865e048cda233449 (diff) | |
| parent | 1c85b45117ad2cb7979f8f6580be965227f9241f (diff) | |
| download | rust-bd82de0de69d72fcdb9054c70d2a1ee8328e5480.tar.gz rust-bd82de0de69d72fcdb9054c70d2a1ee8328e5480.zip | |
Rollup merge of #65007 - BO41:keywords, r=nikomatsakis
Mention keyword closing policy closes #59233 / https://github.com/rust-lang/rust/issues/59233#issuecomment-478362693 rewording suggestions welcome > Also in the referenced issue, the commit number of the new commit > that could close that issue is not really informative. The PR number itself appeared in the issue > is more informative and concise. @lzutao what do you mean with that? Is this fixed by the new "May be fixed by #XXXXX"?
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c3a9a68963e..37a217d2a04 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -128,6 +128,14 @@ the master branch to your feature branch. Also, please make sure that fixup commits are squashed into other related commits with meaningful commit messages. +GitHub allows [closing issues using keywords][closing-keywords]. This feature +should be used to keep the issue tracker tidy. However, it is generally preferred +to put the "closes #123" text in the PR description rather than the issue commit; +particularly during rebasing, citing the issue number in the commit can "spam" +the issue in question. + +[closing-keywords]: https://help.github.com/en/articles/closing-issues-using-keywords + Please make sure your pull request is in compliance with Rust's style guidelines by running |