about summary refs log tree commit diff
path: root/INSTALL.md
diff options
context:
space:
mode:
authorMatt Harding <majaharding@gmail.com>2024-03-07 03:09:29 +0000
committerMatt Harding <majaharding@gmail.com>2024-03-07 03:09:29 +0000
commitc7a48a507ad10617869ed1fbd3f510fd5ad93584 (patch)
tree435a5e35c2130add3ccc7402f8f5ebdb71ec5033 /INSTALL.md
parente27c4722d364e0367a436f7d89c493eeb8ccf8ee (diff)
downloadrust-c7a48a507ad10617869ed1fbd3f510fd5ad93584.tar.gz
rust-c7a48a507ad10617869ed1fbd3f510fd5ad93584.zip
Revert back to Git-for-Windows for MinGW CI builds
In https://github.com/rust-lang/rust/pull/121182 the mingw build was
changed to use MSYS2's version of Git. This commit reverts that, as
it was considered too slow.
Diffstat (limited to 'INSTALL.md')
-rw-r--r--INSTALL.md20
1 files changed, 13 insertions, 7 deletions
diff --git a/INSTALL.md b/INSTALL.md
index d7e0fd72044..03e7a3431a5 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -145,6 +145,15 @@ toolchain.
 
 1. Download the latest [MSYS2 installer][msys2] and go through the installer.
 
+2. Download and install [Git for Windows](https://git-scm.com/download/win).
+   Make sure that it's in your Windows PATH. To enable access to it from within
+   MSYS2, edit the relevant `mingw[32|64].ini` file in your MSYS2 installation
+   directory and uncomment the line `MSYS2_PATH_TYPE=inherit`.
+
+   You could install and use MSYS2's version of git instead with `pacman`,
+   however this is not recommended as it's excrutiatingly slow, and not frequently
+   tested for compatability.
+
 2. Start a MINGW64 or MINGW32 shell (depending on whether you want 32-bit
    or 64-bit Rust) either from your start menu, or by running `mingw64.exe`
    or `mingw32.exe` from your MSYS2 installation directory (e.g. `C:\msys64`).
@@ -160,8 +169,7 @@ toolchain.
    # Note that it is important that you do **not** use the 'python2', 'cmake',
    # and 'ninja' packages from the 'msys2' subsystem.
    # The build has historically been known to fail with these packages.
-   pacman -S git \
-               make \
+   pacman -S make \
                diffutils \
                tar \
                mingw-w64-x86_64-python \
@@ -176,11 +184,9 @@ toolchain.
    python x.py setup dist && python x.py build && python x.py install
    ```
 
-If you want to use the native versions of Git, Python, or CMake you can remove
-them from the above pacman command and install them from another source. Make
-sure that they're in your Windows PATH, and edit the relevant `mingw[32|64].ini`
-file in your MSYS2 installation directory by uncommenting the line
-`MSYS2_PATH_TYPE=inherit` to include them in your MSYS2 PATH.
+If you want to try the native Windows versions of Python or CMake, you can remove
+them from the above pacman command and install them from another source. Follow
+the instructions in step 2 to get them on PATH.
 
 Using Windows native Python can be helpful if you get errors when building LLVM.
 You may also want to use Git for Windows, as it is often *much* faster. Turning