diff options
| author | Alex Macleod <alex@macleod.io> | 2022-04-04 16:30:38 +0100 |
|---|---|---|
| committer | Alex Macleod <alex@macleod.io> | 2022-04-10 17:05:07 +0100 |
| commit | 6fba89751bfacf59109d37331ec79a8f87ee0aaf (patch) | |
| tree | ae6706e98d67affa1e7d4177db99c67642d9166c /clippy_lints/src/methods/mod.rs | |
| parent | 1cec8b30fac2c13504de7e7f950bd36c497858b1 (diff) | |
Remove overlap between `manual_split_once` and `needless_splitn`
Also fixes some incorrect suggestions for rsplitn
Diffstat (limited to 'clippy_lints/src/methods/mod.rs')
| -rw-r--r-- | clippy_lints/src/methods/mod.rs | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs index 021337280d1..7047aa4c69b 100644 --- a/clippy_lints/src/methods/mod.rs +++ b/clippy_lints/src/methods/mod.rs @@ -2516,12 +2516,7 @@ fn check_methods<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>, msrv: Optio ("splitn" | "rsplitn", [count_arg, pat_arg]) => { if let Some((Constant::Int(count), _)) = constant(cx, cx.typeck_results(), count_arg) { suspicious_splitn::check(cx, name, expr, recv, count); - if count == 2 && meets_msrv(msrv, &msrvs::STR_SPLIT_ONCE) { - str_splitn::check_manual_split_once(cx, name, expr, recv, pat_arg); - } - if count >= 2 { - str_splitn::check_needless_splitn(cx, name, expr, recv, pat_arg, count); - } + str_splitn::check(cx, name, expr, recv, pat_arg, count, msrv); } }, ("splitn_mut" | "rsplitn_mut", [count_arg, _]) => { |
