diff options
| author | bors <bors@rust-lang.org> | 2023-08-21 07:38:29 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-08-21 07:38:29 +0000 |
| commit | a3892f0ed9b169351495b0ac871a63bdc5b61317 (patch) | |
| tree | 1c4c421f99286ff618e76eab6bf2bf99a6fd3d62 /compiler/rustc_codegen_gcc/example/std_example.rs | |
| parent | 83b3ba1b8191c065bb0dacc79e5896f7f21e4611 (diff) | |
| parent | 37e0e8af10514a2064915389f22743fb690e3f93 (diff) | |
| download | rust-a3892f0ed9b169351495b0ac871a63bdc5b61317.tar.gz rust-a3892f0ed9b169351495b0ac871a63bdc5b61317.zip | |
Auto merge of #15374 - jmintb:extern_crate, r=Veykril
feat: Implement extern crate completion Hi, this is a draft PR for #13002. I have basic completion working as well as a filter for existing extern crate imports in the same file. This is based on the tests, I have not actually tried this in an editor. Before going further I think this is a good point to stop and get feedback on the structure and approach I have taken so far. Let me know what you think :) I will make sure to add more tests, rebase commits and align with the code style guidelines before submitting a final version. A few specific questions : 1. Is there a better way to check for matching suggestions? right now I just test if an extern crate name starts with the current user input. 2. Am I creating the `CompletionItem` correctly? I noticed that `use_.rs` invokes a builder where as I do not. 3. When checking for existing extern crate imports the current implementation only looks at the current source file, is that sufficient?
Diffstat (limited to 'compiler/rustc_codegen_gcc/example/std_example.rs')
0 files changed, 0 insertions, 0 deletions