diff options
| author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2024-11-02 03:08:49 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-02 03:08:49 +0800 |
| commit | 526c67f37be44688345aec14f7b1c5926f4a59a7 (patch) | |
| tree | 7166070c663b19453451de86923c27efa7e0d1d5 /compiler/rustc_codegen_llvm/src/back/write.rs | |
| parent | 5ca0e9fa9b2f92b463a0a2b0b34315e09c0b7236 (diff) | |
| parent | ce3e14a448e090abf494a91b87f124258c542d4c (diff) | |
| download | rust-526c67f37be44688345aec14f7b1c5926f4a59a7.tar.gz rust-526c67f37be44688345aec14f7b1c5926f4a59a7.zip | |
Rollup merge of #131829 - Zalathar:goodbye-zprofile, r=chenyukang
Remove support for `-Zprofile` (gcov-style coverage instrumentation) Tracking issue: #42524 MCP: https://github.com/rust-lang/compiler-team/issues/798 --- This PR removes the unstable `-Zprofile` flag, which enables ”gcov-style” coverage instrumentation, along with its associated `-Zprofile-emit` configuration flag. (The profile flag predates and is almost entirely separate from the stable `-Cinstrument-coverage` flag.) Notably, the `-Zprofile` flag: - Is largely untested in-tree, having only one run-make test that does not check whether its output is correct or useful. - Has no known maintainer. - Has seen no push towards stabilization. - Has at least one severe regression reported in 2022 that apparently remains unaddressed. - #100125 - Is confusingly named, since it appears to be more about coverage than performance profiling, and has nothing to do with PGO. - Is fundamentally limited by relying on counters auto-inserted by LLVM, with no knowledge of Rust beyond debuginfo.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/back/write.rs')
| -rw-r--r-- | compiler/rustc_codegen_llvm/src/back/write.rs | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/compiler/rustc_codegen_llvm/src/back/write.rs b/compiler/rustc_codegen_llvm/src/back/write.rs index bfa9e8b82a0..cf7b16c9cc4 100644 --- a/compiler/rustc_codegen_llvm/src/back/write.rs +++ b/compiler/rustc_codegen_llvm/src/back/write.rs @@ -591,7 +591,6 @@ pub(crate) unsafe fn llvm_optimize( pgo_use_path.as_ref().map_or(std::ptr::null(), |s| s.as_ptr()), config.instrument_coverage, instr_profile_output_path.as_ref().map_or(std::ptr::null(), |s| s.as_ptr()), - config.instrument_gcov, pgo_sample_use_path.as_ref().map_or(std::ptr::null(), |s| s.as_ptr()), config.debug_info_for_profiling, llvm_selfprofiler, |