summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/common.rs
diff options
context:
space:
mode:
authorFlakebi <flakebi@t-online.de>2025-01-24 00:37:05 +0100
committerFlakebi <flakebi@t-online.de>2025-01-24 00:37:05 +0100
commitb06e840d9e8e27ac1f79be5e6d2778455146f665 (patch)
tree8cda05ea1259452e50e0ad409a7eec8587f70d6d /compiler/rustc_codegen_llvm/src/common.rs
parent436e4fb647bca08bd5cb7eea6f8450bb56515c10 (diff)
downloadrust-b06e840d9e8e27ac1f79be5e6d2778455146f665.tar.gz
rust-b06e840d9e8e27ac1f79be5e6d2778455146f665.zip
Add comments about address spaces
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/common.rs')
-rw-r--r--compiler/rustc_codegen_llvm/src/common.rs2
1 files changed, 2 insertions, 0 deletions
diff --git a/compiler/rustc_codegen_llvm/src/common.rs b/compiler/rustc_codegen_llvm/src/common.rs
index bd792c02810..5031df06b05 100644
--- a/compiler/rustc_codegen_llvm/src/common.rs
+++ b/compiler/rustc_codegen_llvm/src/common.rs
@@ -221,6 +221,7 @@ impl<'ll, 'tcx> ConstCodegenMethods<'tcx> for CodegenCx<'ll, 'tcx> {
                     llvm::LLVMSetUnnamedAddress(g, llvm::UnnamedAddr::Global);
                 }
                 llvm::set_linkage(g, llvm::Linkage::InternalLinkage);
+                // Cast to default address space if globals are in a different addrspace
                 let g = self.const_pointercast(g, self.type_ptr());
                 (s.to_owned(), g)
             })
@@ -324,6 +325,7 @@ impl<'ll, 'tcx> ConstCodegenMethods<'tcx> for CodegenCx<'ll, 'tcx> {
                 let llval = unsafe {
                     llvm::LLVMConstInBoundsGEP2(
                         self.type_i8(),
+                        // Cast to the required address space if necessary
                         self.const_pointercast(base_addr, self.type_ptr_ext(base_addr_space)),
                         &self.const_usize(offset.bytes()),
                         1,