about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/context.rs
diff options
context:
space:
mode:
authorJack Wrenn <jack@wrenn.fyi>2024-12-06 17:11:36 +0000
committerJack Wrenn <jack@wrenn.fyi>2024-12-07 20:50:00 +0000
commit3ce35a4ec5f06828f908a018da083af5eb54301a (patch)
tree23f073f2fb0ee1d071550e88ee7d36f2a7d1e9e8 /compiler/rustc_codegen_llvm/src/context.rs
parent9c707a8b769523bb6768bf58e74fa2c39cc24844 (diff)
downloadrust-3ce35a4ec5f06828f908a018da083af5eb54301a.tar.gz
rust-3ce35a4ec5f06828f908a018da083af5eb54301a.zip
Make `Copy` unsafe to implement for ADTs with `unsafe` fields
As a rule, the application of `unsafe` to a declaration requires that use-sites
of that declaration also require `unsafe`. For example, a field declared
`unsafe` may only be read in the lexical context of an `unsafe` block.

For nearly all safe traits, the safety obligations of fields are explicitly
discharged when they are mentioned in method definitions. For example,
idiomatically implementing `Clone` (a safe trait) for a type with unsafe fields
will require `unsafe` to clone those fields.

Prior to this commit, `Copy` violated this rule. The trait is marked safe, and
although it has no explicit methods, its implementation permits reads of `Self`.

This commit resolves this by making `Copy` conditionally safe to implement. It
remains safe to implement for ADTs without unsafe fields, but unsafe to
implement for ADTs with unsafe fields.

Tracking: #132922
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/context.rs')
0 files changed, 0 insertions, 0 deletions