diff options
| author | Zalathar <Zalathar@users.noreply.github.com> | 2023-07-07 17:07:48 +1000 |
|---|---|---|
| committer | Zalathar <Zalathar@users.noreply.github.com> | 2023-07-13 11:31:15 +1000 |
| commit | 352d0315998c3691e811d8406ae7931143cf7a16 (patch) | |
| tree | e9f5b93844083465da4f9bf6c908e85ad7a23350 /compiler/rustc_codegen_llvm/src/coverageinfo/mod.rs | |
| parent | 7292608e213ddf64e2ecf69c6e074d7d67a2c9ec (diff) | |
| download | rust-352d0315998c3691e811d8406ae7931143cf7a16.tar.gz rust-352d0315998c3691e811d8406ae7931143cf7a16.zip | |
Remove `LLVMRustCoverageHashCString`
Coverage has two FFI functions for computing the hash of a byte string. One takes a ptr/len pair, and the other takes a NUL-terminated C string. But on closer inspection, the C string version is unnecessary. The calling-side code converts a Rust `&str` into a C string, and the C++ code then immediately turns it back into a ptr/len string before actually hashing it.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/coverageinfo/mod.rs')
| -rw-r--r-- | compiler/rustc_codegen_llvm/src/coverageinfo/mod.rs | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/compiler/rustc_codegen_llvm/src/coverageinfo/mod.rs b/compiler/rustc_codegen_llvm/src/coverageinfo/mod.rs index 090e88003d6..1d4a3145cd4 100644 --- a/compiler/rustc_codegen_llvm/src/coverageinfo/mod.rs +++ b/compiler/rustc_codegen_llvm/src/coverageinfo/mod.rs @@ -373,11 +373,6 @@ pub(crate) fn write_mapping_to_buffer( } } -pub(crate) fn hash_str(strval: &str) -> u64 { - let strval = CString::new(strval).expect("null error converting hashable str to C string"); - unsafe { llvm::LLVMRustCoverageHashCString(strval.as_ptr()) } -} - pub(crate) fn hash_bytes(bytes: &[u8]) -> u64 { unsafe { llvm::LLVMRustCoverageHashByteArray(bytes.as_ptr().cast(), bytes.len()) } } |
