about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/errors.rs
diff options
context:
space:
mode:
authorVladimir Makayev <vmakaev@fb.com>2024-04-22 18:55:29 -0700
committerVladimir Makayev <vmakaev@fb.com>2024-05-05 17:53:02 -0700
commitfb2d9cdfc54aea306223992e13ce4b2278d9f0c6 (patch)
tree1b6b29b0dabb5143810e274658cdb45cbb5bc6e3 /compiler/rustc_codegen_llvm/src/errors.rs
parent9c9b568792ef20d8459c745345dd3e79b7c7fa8c (diff)
downloadrust-fb2d9cdfc54aea306223992e13ce4b2278d9f0c6.tar.gz
rust-fb2d9cdfc54aea306223992e13ce4b2278d9f0c6.zip
Implement lldb formattter for "clang encoded" enums (LLDB 18.1+)
Summary:
I landed a fix last year to enable `DW_TAG_variant_part` encoding in LLDBs (https://reviews.llvm.org/D149213). This PR is a corresponding fix in synthetic formatters to decode that information.
This is in no way perfect implementation but at least it improves the status quo. But most types of enums will be visible and debuggable in some way.
I've also updated most of the existing tests that touch enums and re-enabled test cases based on LLDB for enums.

Test Plan:
ran tests `./x test tests/debuginfo/`. Also tested manually in LLDB CLI and LLDB VSCode

Other Thoughs
A better approach would probably be adopting [formatters from codelldb](https://github.com/vadimcn/codelldb/blob/master/formatters/rust.py). There is some neat hack that hooks up summary provider via synthetic provider which can ultimately fix more display issues for Rust types and enums too. But getting it to work well might take more time that I have right now.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/errors.rs')
0 files changed, 0 insertions, 0 deletions