about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src/llvm/ffi.rs
diff options
context:
space:
mode:
authorZalathar <Zalathar@users.noreply.github.com>2024-12-08 00:10:39 +1100
committerZalathar <Zalathar@users.noreply.github.com>2025-02-01 14:14:40 +1100
commit5413d2bd6fd23103a8f44b306cdc6da1e109b6a2 (patch)
tree8d31bd470d59a4adf4207dd45140b4bfd61473f4 /compiler/rustc_codegen_llvm/src/llvm/ffi.rs
parent8ddd9c38f6165d40ca1ab82e1d2bf9890a047c3a (diff)
downloadrust-5413d2bd6fd23103a8f44b306cdc6da1e109b6a2.tar.gz
rust-5413d2bd6fd23103a8f44b306cdc6da1e109b6a2.zip
Add FIXME for auditing optional parameters passed to DIBuilder
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/llvm/ffi.rs')
-rw-r--r--compiler/rustc_codegen_llvm/src/llvm/ffi.rs4
1 files changed, 4 insertions, 0 deletions
diff --git a/compiler/rustc_codegen_llvm/src/llvm/ffi.rs b/compiler/rustc_codegen_llvm/src/llvm/ffi.rs
index 95896916adc..222e69df335 100644
--- a/compiler/rustc_codegen_llvm/src/llvm/ffi.rs
+++ b/compiler/rustc_codegen_llvm/src/llvm/ffi.rs
@@ -1712,6 +1712,10 @@ unsafe extern "C" {
 
 // FFI bindings for `DIBuilder` functions in the LLVM-C API.
 // Try to keep these in the same order as in `llvm/include/llvm-c/DebugInfo.h`.
+//
+// FIXME(#134001): Audit all `Option` parameters, especially in lists, to check
+// that they really are nullable on the C/C++ side. LLVM doesn't appear to
+// actually document which ones are nullable.
 unsafe extern "C" {
     pub(crate) fn LLVMCreateDIBuilder<'ll>(M: &'ll Module) -> *mut DIBuilder<'ll>;
     pub(crate) fn LLVMDisposeDIBuilder<'ll>(Builder: ptr::NonNull<DIBuilder<'ll>>);