diff options
| author | bors <bors@rust-lang.org> | 2020-09-26 01:36:50 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2020-09-26 01:36:50 +0000 |
| commit | c6622d1d05d1ea58cfd9b56cc3a91b2c17316c96 (patch) | |
| tree | cf6a3a83acac49fed56f127a105fa6d50fed6633 /compiler/rustc_codegen_llvm/src/llvm_util.rs | |
| parent | 043f6d747c15068f0053a0542e9b0f17ae7f4de4 (diff) | |
| parent | 5946c12476b488dbc4555741321321a1cbd4d68c (diff) | |
| download | rust-c6622d1d05d1ea58cfd9b56cc3a91b2c17316c96.tar.gz rust-c6622d1d05d1ea58cfd9b56cc3a91b2c17316c96.zip | |
Auto merge of #76176 - marmeladema:fix-closure-path-printing, r=eddyb
Move from {{closure}}#0 syntax to {closure#0} for (def) path components
Part of #70334
I followed the approach described by `@eddyb` and introduced a `DefPathDataName` enum.
To preserve compatibility, in various places, I had to rely on formatting manually by calling `format!("{{{{{}}}}}", namespace)`.
My questions are:
* Do we want to convert for places to use the new naming scheme? Or shall I re-add `DefPathData::as_symbol` but renamed as `DefPathData::as_legacy_symbol` to avoid manually allocating the legacy symbols?
* Do we want to `impl Display for DisambiguatedDefPathData` to avoid manually calling `write!(s, "{{{}#{}}}", namespace, component.disambiguator)`?
* We might also want to improve naming for `DefPathDataName` and `DefPathData::get_name`
r? `@eddyb`
Diffstat (limited to 'compiler/rustc_codegen_llvm/src/llvm_util.rs')
0 files changed, 0 insertions, 0 deletions