diff options
| author | katelyn a. martin <me+rustlang@katelyn.world> | 2020-10-23 18:49:34 -0400 |
|---|---|---|
| committer | katelyn a. martin <me+rustlang@katelyn.world> | 2021-03-09 14:40:33 -0500 |
| commit | 05bf037fecfad619e140877769379a1d24952bad (patch) | |
| tree | c109a2e7e2b610e1ca4809f83be00d8a51ccca25 /compiler/rustc_codegen_llvm/src | |
| parent | baf227ea0c1e07fc54395a51e4b3881d701180cb (diff) | |
| download | rust-05bf037fecfad619e140877769379a1d24952bad.tar.gz rust-05bf037fecfad619e140877769379a1d24952bad.zip | |
address pr review comments
### Add debug assertion to check `AbiDatas` ordering
This makes a small alteration to `Abi::index`, so that we include a
debug assertion to check that the index we are returning corresponds
with the same abi in our data array.
This will help prevent ordering bugs in the future, which can
manifest in rather strange errors.
### Using exhaustive ABI matches
This slightly modifies the changes from our previous commits,
favoring exhaustive matches in place of `_ => ...` fall-through
arms.
This should help with maintenance in the future, when additional
ABI's are added, or when existing ABI's are modified.
### List all `-unwind` ABI's in unstable book
This updates the `c-unwind` page in the unstable book to list _all_
of the other ABI strings that are introduced by this feature gate.
Now, all of the ABI's specified by RFC 2945 are shown.
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
Co-authored-by: Niko Matsakis <niko@alum.mit.edu>
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions