about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-08-11 12:43:14 +0000
committerbors <bors@rust-lang.org>2024-08-11 12:43:14 +0000
commit5e5ec8af1b34a71fbf0063586a70bae7460a892a (patch)
tree9f8e7a8d481fd776fdddb4a494534b3e374e69af /compiler/rustc_codegen_llvm/src
parentc9bd03cb724e13cca96ad320733046cbdb16fbbe (diff)
parent6dc300ba4531b855132ac8b3ac38f7bb73c8fe52 (diff)
downloadrust-5e5ec8af1b34a71fbf0063586a70bae7460a892a.tar.gz
rust-5e5ec8af1b34a71fbf0063586a70bae7460a892a.zip
Auto merge of #128916 - jieyouxu:dump-ice-dump-ice, r=compiler-errors
Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages

For the future traveler: **if you did a `git blame` and found this PR that last modified `dump-ice-to-disk` because the test failed in a completely unrelated PR, then I'm afraid our ICE dump may have regressed or somehow behaves differently on `i686-mingw`.**

A bit of clean up to the `dump-ice-to-disk` test.

- Fixes/updates the top-level comment.
- Add a FIXME pointing to #128911 for flakiness.
- Instead of trying to manually cleanup `rustc-ice*.txt` dumps, run each test instance in a separate temp directory.
- Explicitly make `RUSTC_ICE` unavailable in one of the `-Zmetrics-dir` test case to not have interference from environment.
- Make assertion failures (on ICE dump line count mismatch) extremely verbose to help debug why this test is flakey in CI (#128911).

Contains a fix by `@saethlin` in #128909, should wait until that is merged then rebase on top.

try-job: aarch64-gnu
try-job: aarch64-apple
try-job: x86_64-msvc
try-job: i686-mingw
try-job: test-various
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions