about summary refs log tree commit diff
path: root/compiler/rustc_codegen_llvm/src
diff options
context:
space:
mode:
authorYuki Okushi <jtitor@2k36.org>2021-05-01 18:32:35 +0900
committerGitHub <noreply@github.com>2021-05-01 18:32:35 +0900
commita4dbb8c9097157c8e51002c0b4d4216e04466338 (patch)
treee0e092e9111a1f3dd1a7059550bd7f1d97945ff0 /compiler/rustc_codegen_llvm/src
parent4d6d26ec6d6211890c5a3590555b22cd99b5f32c (diff)
parentbea99a5da6acaa30cf27cd8d6268527ff24ee77e (diff)
downloadrust-a4dbb8c9097157c8e51002c0b4d4216e04466338.tar.gz
rust-a4dbb8c9097157c8e51002c0b4d4216e04466338.zip
Rollup merge of #84740 - r00ster91:patch-6, r=GuillaumeGomez
Reset the docs' copy path button after 1 second

I like that this copy path button on the top next to the type/module's name changes to a check mark when you successfully clicked and copied the path but I find it really weird how the icon stays that check mark forever after the first time of clicking it. Imagine you leave that documentation tab open and come back after 2 hours and you still see that check mark in that box because you copied the path 2 hours ago. You will probably be confused and you might've forgotten what that button even does (even more so currently where this is a new feature, or when you simply don't use it often), so I really think at some point it should go back to the ⎘ icon which, at least to me, pretty clearly indicates copying, whereas the check mark (if it stays there for so long) could falsely look like a verification mark indicating "this module is verified" or something like that.
I believe after a longer period of time it's not logical to still tell the user "yes you've copied this successful".

In addition to this timeout, maybe it could be made so that you can't copy again until this cooldown of 1 second is over, but I'm not sure how useful or user-friendly that feature would be so maybe it's fine the way it is now.
Also the timeout is cleared every time you click again so if you constantly click it, it won't reset during that.
Diffstat (limited to 'compiler/rustc_codegen_llvm/src')
0 files changed, 0 insertions, 0 deletions