diff options
| author | Ralf Jung <post@ralfj.de> | 2024-05-15 17:33:26 +0200 |
|---|---|---|
| committer | Ralf Jung <post@ralfj.de> | 2024-05-15 17:35:16 +0200 |
| commit | 17bd43cb250ff3bf0c29d021e232969d9d1765fa (patch) | |
| tree | 4432599da1f6580b61bf6e696158aa503d36342a /compiler/rustc_codegen_ssa/src/base.rs | |
| parent | ade234d5743795423db6cc7cd52541390a088eab (diff) | |
| download | rust-17bd43cb250ff3bf0c29d021e232969d9d1765fa.tar.gz rust-17bd43cb250ff3bf0c29d021e232969d9d1765fa.zip | |
codegen: tweak/extend shift comments
Diffstat (limited to 'compiler/rustc_codegen_ssa/src/base.rs')
| -rw-r--r-- | compiler/rustc_codegen_ssa/src/base.rs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/compiler/rustc_codegen_ssa/src/base.rs b/compiler/rustc_codegen_ssa/src/base.rs index 877e5b75912..e7cc2cb1a0b 100644 --- a/compiler/rustc_codegen_ssa/src/base.rs +++ b/compiler/rustc_codegen_ssa/src/base.rs @@ -293,12 +293,13 @@ pub fn coerce_unsized_into<'a, 'tcx, Bx: BuilderMethods<'a, 'tcx>>( } } -/// Returns `rhs` sufficiently masked, truncated, and/or extended so that -/// it can be used to shift `lhs`. +/// Returns `rhs` sufficiently masked, truncated, and/or extended so that it can be used to shift +/// `lhs`: it has the same size as `lhs`, and the value, when interpreted unsigned (no matter its +/// type), will not exceed the size of `lhs`. /// -/// Shifts in MIR are all allowed to have mismatched LHS & RHS types. +/// Shifts in MIR are all allowed to have mismatched LHS & RHS types, and signed RHS. /// The shift methods in `BuilderMethods`, however, are fully homogeneous -/// (both parameters and the return type are all the same type). +/// (both parameters and the return type are all the same size) and assume an unsigned RHS. /// /// If `is_unchecked` is false, this masks the RHS to ensure it stays in-bounds, /// as the `BuilderMethods` shifts are UB for out-of-bounds shift amounts. |
