about summary refs log tree commit diff
path: root/compiler/rustc_const_eval/messages.ftl
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2025-07-16 17:06:38 +0200
committerGitHub <noreply@github.com>2025-07-16 17:06:38 +0200
commit17332ed91648d84ab317e772d5611c74c1df06aa (patch)
treeb0b5b46f1fb5063080b5a1869a79a6b2692c789f /compiler/rustc_const_eval/messages.ftl
parent37aba8388e93c9beeb092cbfa4540555d67a0af9 (diff)
parent148a220e38f0b2ba4ec8014d0c1e83ca6d52d47e (diff)
downloadrust-17332ed91648d84ab317e772d5611c74c1df06aa.tar.gz
rust-17332ed91648d84ab317e772d5611c74c1df06aa.zip
Rollup merge of #143448 - Enselic:remote-test-client-signals, r=Mark-Simulacrum
remote-test-client: Exit code `128 + <signal-number>` instead of `3`

If the remote process is terminated by a signal, make `remote-test-client` exit with the code `128 + <signal-number>` instead of always `3`. This follows common practice among tools such as bash [^1]:

> When a command terminates on a fatal signal whose number is N, Bash uses the
> value 128+N as the exit status.

It also allows us to differentiate between `run-pass` and `run-crash` ui tests without special case code in compiletest for that when `remote-test-client` is used. See https://github.com/rust-lang/rust/pull/143002 and in particular https://github.com/rust-lang/rust/pull/143002#issuecomment-3037061667.

Exiting with code `3` has been done from the start (see https://github.com/rust-lang/rust/pull/39400) and seems arbitrary rather than a deliberate design decision, so changing it does not seem like an extraordinarily big deal.

### Regression testing

Note that https://github.com/rust-lang/rust/pull/143002 will act as a regression test once it is rebased on this PR.

### Why a separate PR

I think it is comforting to know that CI does not break with just this change. But if my reviewer prefers, we can move this commit to be part of https://github.com/rust-lang/rust/pull/143002 instead.

[^1]: https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html
Diffstat (limited to 'compiler/rustc_const_eval/messages.ftl')
0 files changed, 0 insertions, 0 deletions