about summary refs log tree commit diff
path: root/compiler/rustc_errors/src/json.rs
diff options
context:
space:
mode:
authorUrgau <3616612+Urgau@users.noreply.github.com>2024-06-26 17:00:46 +0200
committerGitHub <noreply@github.com>2024-06-26 17:00:46 +0200
commit7666534381042f5febdc995e024af051ceecc2f5 (patch)
treec38b76fb7c3a24b72b0681bcdaecdf388e204fba /compiler/rustc_errors/src/json.rs
parent1d667a0937f6242366d1f47d359a2c739f3c62b1 (diff)
downloadrust-7666534381042f5febdc995e024af051ceecc2f5.tar.gz
rust-7666534381042f5febdc995e024af051ceecc2f5.zip
Clarify comment on changing to warn future breakage items
https://github.com/rust-lang/rust/pull/120924/files#r1653512240
Diffstat (limited to 'compiler/rustc_errors/src/json.rs')
-rw-r--r--compiler/rustc_errors/src/json.rs10
1 files changed, 5 insertions, 5 deletions
diff --git a/compiler/rustc_errors/src/json.rs b/compiler/rustc_errors/src/json.rs
index 3d2a04d5851..764134d5335 100644
--- a/compiler/rustc_errors/src/json.rs
+++ b/compiler/rustc_errors/src/json.rs
@@ -135,11 +135,11 @@ impl Emitter for JsonEmitter {
         let data: Vec<FutureBreakageItem<'_>> = diags
             .into_iter()
             .map(|mut diag| {
-                // The `FutureBreakageItem` is collected and serialized.
-                // However, the `allow` and `expect` lint levels can't usually
-                // be serialized. The lint level is overwritten to allow the
-                // serialization again and force a lint emission.
-                // (This is an educated guess. I didn't originally add this)
+                // Allowed or expected lints don't normally (by definition) emit a lint
+                // but future incompat lints are special and are emitted anyway.
+                //
+                // So to avoid ICEs and confused users we "upgrade" the lint level for
+                // those `FutureBreakageItem` to warn.
                 if matches!(diag.level, crate::Level::Allow | crate::Level::Expect(..)) {
                     diag.level = crate::Level::Warning;
                 }