diff options
| author | David Tolnay <dtolnay@gmail.com> | 2021-07-08 20:24:29 -0700 |
|---|---|---|
| committer | David Tolnay <dtolnay@gmail.com> | 2021-07-18 14:08:34 -0700 |
| commit | 55ff45a5c25c49e665a9459b8d6ea03ae2c44476 (patch) | |
| tree | 454ce7299b38c0e9552a98c023a5a0ab5a271ebf /compiler/rustc_expand/src | |
| parent | 331da5820cfeb937dcdd76192d97a5fc4dd115c8 (diff) | |
| download | rust-55ff45a5c25c49e665a9459b8d6ea03ae2c44476.tar.gz rust-55ff45a5c25c49e665a9459b8d6ea03ae2c44476.zip | |
Support negative numbers in Literal::from_str
Diffstat (limited to 'compiler/rustc_expand/src')
| -rw-r--r-- | compiler/rustc_expand/src/proc_macro_server.rs | 63 |
1 files changed, 41 insertions, 22 deletions
diff --git a/compiler/rustc_expand/src/proc_macro_server.rs b/compiler/rustc_expand/src/proc_macro_server.rs index ff135f60a82..8404e16fd1e 100644 --- a/compiler/rustc_expand/src/proc_macro_server.rs +++ b/compiler/rustc_expand/src/proc_macro_server.rs @@ -1,7 +1,7 @@ use crate::base::{ExtCtxt, ResolverExpand}; use rustc_ast as ast; -use rustc_ast::token::{self, Nonterminal, NtIdent, TokenKind}; +use rustc_ast::token::{self, Nonterminal, NtIdent}; use rustc_ast::tokenstream::{self, CanSynthesizeMissingTokens}; use rustc_ast::tokenstream::{DelimSpan, Spacing::*, TokenStream, TreeAndSpacing}; use rustc_ast_pretty::pprust; @@ -537,30 +537,49 @@ impl server::Ident for Rustc<'_> { impl server::Literal for Rustc<'_> { fn from_str(&mut self, s: &str) -> Result<Self::Literal, ()> { - let override_span = None; - let stream = parse_stream_from_source_str( - FileName::proc_macro_source_code(s), - s.to_owned(), - self.sess, - override_span, - ); - if stream.len() != 1 { - return Err(()); - } - let tree = stream.into_trees().next().unwrap(); - let token = match tree { - tokenstream::TokenTree::Token(token) => token, - tokenstream::TokenTree::Delimited { .. } => return Err(()), + let name = FileName::proc_macro_source_code(s); + let mut parser = rustc_parse::new_parser_from_source_str(self.sess, name, s.to_owned()); + + let first_span = parser.token.span.data(); + let minus_present = parser.eat(&token::BinOp(token::Minus)); + + let lit_span = parser.token.span.data(); + let mut lit = match parser.token.kind { + token::Literal(lit) => lit, + _ => return Err(()), }; - let span_data = token.span.data(); - if (span_data.hi.0 - span_data.lo.0) as usize != s.len() { - // There is a comment or whitespace adjacent to the literal. + + // Check no comment or whitespace surrounding the (possibly negative) + // literal, or more tokens after it. + if (lit_span.hi.0 - first_span.lo.0) as usize != s.len() { return Err(()); } - let lit = match token.kind { - TokenKind::Literal(lit) => lit, - _ => return Err(()), - }; + + if minus_present { + // If minus is present, check no comment or whitespace in between it + // and the literal token. + if first_span.hi.0 != lit_span.lo.0 { + return Err(()); + } + + // Check literal is a kind we allow to be negated in a proc macro token. + match lit.kind { + token::LitKind::Bool + | token::LitKind::Byte + | token::LitKind::Char + | token::LitKind::Str + | token::LitKind::StrRaw(_) + | token::LitKind::ByteStr + | token::LitKind::ByteStrRaw(_) + | token::LitKind::Err => return Err(()), + token::LitKind::Integer | token::LitKind::Float => {} + } + + // Synthesize a new symbol that includes the minus sign. + let symbol = Symbol::intern(&s[..1 + lit.symbol.len()]); + lit = token::Lit::new(lit.kind, symbol, lit.suffix); + } + Ok(Literal { lit, span: self.call_site }) } fn debug_kind(&mut self, literal: &Self::Literal) -> String { |
