about summary refs log tree commit diff
path: root/compiler/rustc_interface/src/tests.rs
diff options
context:
space:
mode:
authorMatthias Krüger <matthias.krueger@famsik.de>2024-12-19 15:26:06 +0100
committerGitHub <noreply@github.com>2024-12-19 15:26:06 +0100
commitb9784988f797e1dcd3ae1c47549f4697ca36f156 (patch)
tree0dd8cf11919ff9fdf625db4812a0398c21587101 /compiler/rustc_interface/src/tests.rs
parent3bf62ccc1055a94dfa6a72650b10a71dcf232429 (diff)
parent5415f067bd4565fe49c77de426e2f99625311fc6 (diff)
downloadrust-b9784988f797e1dcd3ae1c47549f4697ca36f156.tar.gz
rust-b9784988f797e1dcd3ae1c47549f4697ca36f156.zip
Rollup merge of #134463 - jieyouxu:filecheck-prefix, r=Zalathar
compiletest: don't register predefined `MSVC`/`NONMSVC` FileCheck prefixes

This was fragile as it was based on host target passed to compiletest,
but the user could cross-compile and run test for a different target
(e.g. cross from linux to msvc, but msvc won't be set on the target).
Furthermore, it was also very surprising as normally revision names
(other than `CHECK`) was accepted as FileCheck prefixes.

This partially reverts the `MSVC`/`NONMSVC` predefined FileCheck
prefix registration introduced historically for some codegen tests.

This makes some codegen tests more verbose since they now need to
explicitly introduce `MSVC`/`NONMSVC` revisions, but I think that's
less surprising, e.g.:

```rs
//@ revisions: MSVC NONMSVC
//`@[MSVC]` only-msvc
//`@[NONMSVC]` ignore-msvc
```

Note that revisions are not *only* FileCheck prefixes in
FileCheck-based test suites, as they also can be used
to conditionally apply certain compiletest directives.

r? `@Zalathar` (or reroll a `r/? compiletest` reviewer)

try-job: x86_64-msvc
try-job: i686-msvc
try-job: x86_64-mingw-1
try-job: i686-mingw
Diffstat (limited to 'compiler/rustc_interface/src/tests.rs')
0 files changed, 0 insertions, 0 deletions