summary refs log tree commit diff
path: root/compiler/rustc_llvm/build.rs
diff options
context:
space:
mode:
authorNikita Popov <npopov@redhat.com>2024-07-12 14:48:42 +0200
committerNikita Popov <nikita.ppv@gmail.com>2024-07-12 22:13:56 +0200
commit776b0adaafa2198caa0ef6485e3e78a43620a58b (patch)
treee9cb4d09e06255f9274479523b29f56fd3513f3b /compiler/rustc_llvm/build.rs
parent0fdfb61795b40037955154638fe35f20b16c8e55 (diff)
downloadrust-776b0adaafa2198caa0ef6485e3e78a43620a58b.tar.gz
rust-776b0adaafa2198caa0ef6485e3e78a43620a58b.zip
Fix incorrect NDEBUG handling in LLVM bindings
We currently compile our LLVM bindings using `-DNDEBUG` if
debuginfo for LLVM is disabled. However, `NDEBUG` doesn't have
any relation to debuginfo, it controls whether assertions are
enabled.

Rename the environment variable to `LLVM_ASSERTIONS` and drive
it using the `llvm_assertions` option. Also drop the explicit
`debug(false)` call, as cc already sets this up using the
cargo `DEBUG` environment variable.
Diffstat (limited to 'compiler/rustc_llvm/build.rs')
-rw-r--r--compiler/rustc_llvm/build.rs3
1 files changed, 1 insertions, 2 deletions
diff --git a/compiler/rustc_llvm/build.rs b/compiler/rustc_llvm/build.rs
index 3aa852c8304..4c1f78e6bee 100644
--- a/compiler/rustc_llvm/build.rs
+++ b/compiler/rustc_llvm/build.rs
@@ -197,9 +197,8 @@ fn main() {
         cfg.define("LLVM_RUSTLLVM", None);
     }
 
-    if tracked_env_var_os("LLVM_NDEBUG").is_some() {
+    if tracked_env_var_os("LLVM_ASSERTIONS").is_none() {
         cfg.define("NDEBUG", None);
-        cfg.debug(false);
     }
 
     rerun_if_changed_anything_in_dir(Path::new("llvm-wrapper"));