about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2020-11-20 03:40:20 +0000
committerbors <bors@rust-lang.org>2020-11-20 03:40:20 +0000
commit74285eb3a83eac639f9c54ba8c4ccf9879b3b00a (patch)
tree6771c2444c7ce708f710b7649875c81754c56fe6 /compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp
parent4ec27e4b79891b0ebc2ad71a3c4ac94f67d93f93 (diff)
parenta125ef2e8ec27e8fedc119ddfdef638d09a69ba2 (diff)
downloadrust-74285eb3a83eac639f9c54ba8c4ccf9879b3b00a.tar.gz
rust-74285eb3a83eac639f9c54ba8c4ccf9879b3b00a.zip
Auto merge of #78088 - fusion-engineering-forks:panic-fmt-lint, r=estebank
Add lint for panic!("{}")

This adds a lint that warns about `panic!("{}")`.

`panic!(msg)` invocations with a single argument use their argument as panic payload literally, without using it as a format string. The same holds for `assert!(expr, msg)`.

This lints checks if `msg` is a string literal (after expansion), and warns in case it contained braces. It suggests to insert `"{}", ` to use the message literally, or to add arguments to use it as a format string.

![image](https://user-images.githubusercontent.com/783247/96643867-79eb1080-1328-11eb-8d4e-a5586837c70a.png)

This lint is also a good starting point for adding warnings about `panic!(not_a_string)` later, once [`panic_any()`](https://github.com/rust-lang/rust/pull/74622) becomes a stable alternative.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions