diff options
| author | petr-tik <petr-tik@users.noreply.github.com> | 2023-08-20 18:31:25 +0100 |
|---|---|---|
| committer | Lukas Wirth <lukastw97@gmail.com> | 2023-12-08 11:38:54 +0100 |
| commit | 2d879e043176dcb683a43e0a90d17126c0bc22d5 (patch) | |
| tree | 5795255996562bc50543ca15cdce3bd91232da20 /compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp | |
| parent | bc9c952b6d02bf889fff84ba508423b1daca381e (diff) | |
| download | rust-2d879e043176dcb683a43e0a90d17126c0bc22d5.tar.gz rust-2d879e043176dcb683a43e0a90d17126c0bc22d5.zip | |
Stop offering private functions in completions
Before Private functions have RawVisibility module, but were missed because take_types returned None early. After resolve_visibility returned None, Visibility::Public was set instead and private functions ended up being offered in autocompletion. Choosing such a function results in an immediate error diagnostic about using a private function. After Pattern match of take_types that returns None and query for Module-level visibility from the original_module Fix #15134 - tested with a unit test and a manual end-to-end test of building rust-analyzer from my branch and opening the reproduction repository REVIEW Refactor to move scope_def_applicable and check function visibility from a module Please let me know what's the best way to add a unit tests to nameres, which is where the root cause was
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/CoverageMappingWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
