about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/Linker.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-09-13 16:49:16 +0000
committerbors <bors@rust-lang.org>2024-09-13 16:49:16 +0000
commit25367459176bf0fd385594611d5a7c76fbcfa883 (patch)
tree5ab79a72eed508edb055d4ee23740e00ae5e0f51 /compiler/rustc_llvm/llvm-wrapper/Linker.cpp
parent2b7d80b80ab76e3f3dc5b01d991a32663a9d156b (diff)
parent15495ebf42a2d9748ae25774a73f28c43e47fd0b (diff)
downloadrust-25367459176bf0fd385594611d5a7c76fbcfa883.tar.gz
rust-25367459176bf0fd385594611d5a7c76fbcfa883.zip
Auto merge of #13313 - y21:issue13308, r=Centri3
Look at adjusted types instead of fn signature types in `ptr_arg`

This simplifies the implementation of the `ptr_arg` lint a bit and:
Fixes #13308
Fixes #10612

Currently, the lint checks if e.g. a `&String` parameter is only used in contexts where a `&str` could work. Part of it worked by looking for path exprs to that parameter in function call position specifically, looking at the callee signature and checking if that parameter type without refs is `String` (or one of a bunch of other special cases).

This simplified version removes the special casing of function calls and looking at the parameter type and instead just looks at the **adjusted type**, regardless of the expression it's in. This naturally also covers what the previous version was doing (if the expression is in a function call argument position expecting a `&str`, then it will have that adjustment. If it requires a `&String` then it won't have that adjustment and we won't lint).

The linked issue was a FP that happened because the previous implementation simply didn't consider projection types in the signature type, but with this simplification we don't really need to consider that (because we aren't looking at function signatures at all anymore -- the `&mut Self::Owned` parameter type of `clone_into` is the already-instantiated and normalized type `&mut String`).

changelog: none
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/Linker.cpp')
0 files changed, 0 insertions, 0 deletions