about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-08-29 07:44:29 +0000
committerbors <bors@rust-lang.org>2024-08-29 07:44:29 +0000
commite0625d5c0837e3abbb191dff9ed6ef948575884b (patch)
treeea7b151cef9fc8739bc951ca87049433ca8ad588 /compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp
parentb195ff3ac06092ff659c64aa07695760706b76f0 (diff)
parentc2c1bd0c137cf50e578d8749142c21eaf0946f3d (diff)
downloadrust-e0625d5c0837e3abbb191dff9ed6ef948575884b.tar.gz
rust-e0625d5c0837e3abbb191dff9ed6ef948575884b.zip
Auto merge of #17988 - darichey:fix-scip-def, r=Veykril
Fix incorrect symbol definitions in SCIP output

The SCIP output incorrectly marks some symbols as definitions because it doesn't account for the file ID when comparing the token's range to its definition's range.

This means that if a symbol is referenced in a file at the same position at which it is defined in another file, that reference will be marked as a definition. I was quite surprised by how common this is. For example, `PartialEq` is defined [here](https://github.com/rust-lang/rust/blob/1.80.1/library/core/src/cmp.rs#L273) and `uuid` references it [here](https://github.com/uuid-rs/uuid/blob/1.8.0/src/lib.rs#L329). And what do you know, they're both at offset 10083! In our large monorepo, this happens for basically every common stdlib type!
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/PassWrapper.cpp')
0 files changed, 0 insertions, 0 deletions