about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2022-03-02 03:03:22 +0000
committerbors <bors@rust-lang.org>2022-03-02 03:03:22 +0000
commit39a3b527674c1c8d2b9d3edc0cfae67abe6b3ecb (patch)
tree19cad78e9c5434d03b45ff81ef169449e409a12b /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
parentf0c4da49983aa699f715caf681e3154b445fb60b (diff)
parentdf701a292ce552fddad2048cfcb6edaf90222d85 (diff)
downloadrust-39a3b527674c1c8d2b9d3edc0cfae67abe6b3ecb.tar.gz
rust-39a3b527674c1c8d2b9d3edc0cfae67abe6b3ecb.zip
Auto merge of #87402 - nagisa:nagisa/request-feature-requests-for-features, r=estebank
Direct users towards using Rust target feature names in CLI

This PR consists of a couple of changes on how we handle target features.

In particular there is a bug-fix wherein we avoid passing through features that aren't prefixed by `+` or `-` to LLVM. These appear to be causing LLVM to assert, which is pretty poor a behaviour (and also makes it pretty clear we expect feature names to be prefixed).

The other commit, I anticipate to be somewhat more controversial is outputting a warning when users specify a LLVM-specific, or otherwise unknown, feature name on the CLI. In those situations we request users to either replace it with a known Rust feature name (e.g. `bmi` -> `bmi1`) or file a feature request. I've a couple motivations for this: first of all, if users are specifying these features on the command line, I'm pretty confident there is also a need for these features to be usable via `#[cfg(target_feature)]` machinery.  And second, we're growing a fair number of backends recently and having ability to provide some sort of unified-ish interface in this place seems pretty useful to me.

Sponsored by: standard.ai
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions