about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
diff options
context:
space:
mode:
authorDylan DPC <99973273+Dylan-DPC@users.noreply.github.com>2022-06-17 12:21:48 +0200
committerGitHub <noreply@github.com>2022-06-17 12:21:48 +0200
commit74aa55b3fcae638ce3df9111ef7822474f9a2b61 (patch)
tree7aca511f2f562b3b3e588c666443b5127f92ffe8 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
parentb516806774e3ee85abc54105ad6edd13deaa34a2 (diff)
parente502b9a0ff4ab37176c82a994586e6f11e57e18f (diff)
downloadrust-74aa55b3fcae638ce3df9111ef7822474f9a2b61.tar.gz
rust-74aa55b3fcae638ce3df9111ef7822474f9a2b61.zip
Rollup merge of #97798 - WaffleLapkin:allow_for_suggestions_that_are_quite_far_away_from_each_other, r=estebank
Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown

This is an attempt to fix suggestions one part of which is 6 lines or more far from the first. I've noticed "the problem" (of not showing some parts of the suggestion) here: https://github.com/rust-lang/rust/pull/97759#discussion_r889689230.

I'm not sure about the implementation (this big closure is just bad and makes already complicated code even more so), but I want to at least discuss the result.

Here is an example of how this changes the output:

Before:
```text
help: consider enclosing expression in a block
  |
3 ~     'l: { match () { () => break 'l,
4 |
5 |
6 |
7 |
8 |
...
```

After:
```text
help: consider enclosing expression in a block
  |
3 ~     'l: { match () { () => break 'l,
4 |
...
31|
32~ } };
  |
```

r? `@estebank`
`@rustbot` label +A-diagnostics +A-suggestion-diagnostics
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions