about summary refs log tree commit diff
path: root/compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-02-05 06:12:26 +0000
committerbors <bors@rust-lang.org>2021-02-05 06:12:26 +0000
commit9e5d58fb420a487ae30f38141eccdc8d79fb8d58 (patch)
tree841e0654fc71d614351d57ce4ef7842772335534 /compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
parent6a388dcfbb07b3ca3d4ad3fd3902ac7e3b11b5f6 (diff)
parent5ce67106688664eb1bfd8abae129e7c548de0351 (diff)
downloadrust-9e5d58fb420a487ae30f38141eccdc8d79fb8d58.tar.gz
rust-9e5d58fb420a487ae30f38141eccdc8d79fb8d58.zip
Auto merge of #81688 - pnkfelix:fix-llvm-version-check-in-run-make-tests, r=simulacrum
Use `# min-llvm-version: 11.0` to force a minimum LLVM version

Use `# min-llvm-version: 11.0` to force a minimum LLVM version, rather than ad-hoc internal solution.

In particular: the specific code to define LLVM_VERSION_11_PLUS here was, for some reason, using `$(shell ...)` with bash-specific variable replacement code. On non-bash platforms like dash, that `shell` invocation would fail, and the
LLVM_VERSION_11_PLUS check would always fail, the test would always be ignored, and thus be treated as a "success" (in the sense that `--bless` would never do anything).

 * Note in particular that GNU Make treats the SHELL variable as a very special case: it does not inherit the value of SHELL from the user's environment. Except on Windows. See more explanation in the [GNU Make docs](https://www.gnu.org/software/make/manual/html_node/Choosing-the-Shell.html).
 * The effect of this is that these tests end up using `/bin/sh` (except on Windows) for their `$(shell ...)` invocations, and thus we see differing behaviors depending on whether your `/bin/sh` links to `/bin/dash` or to `/bin/bash`.

This was causing me a lot of pain.
Diffstat (limited to 'compiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions